When no document symbol provider use the folding model for the sticky scroll #159198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2022 09:08
|
✨ Very cool! |
jrieken
reviewed
Aug 26, 2022
src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/stickyScroll/browser/stickyScrollProvider.ts
Outdated
Show resolved
Hide resolved
jrieken
reviewed
Aug 26, 2022
jrieken
requested changes
Aug 29, 2022
jrieken
previously approved these changes
Aug 29, 2022
This is because not every test disposes its code editors correctly and leaking contributions (like the `FoldingController`) have weird side-effects (still listening etc). Also, tests at the workbench level don't need editor contribution and editor construction is faster without them fyi @bpasero
jrieken
approved these changes
Aug 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157165. Here is an example of how it works on a python file. The if/else statements and other possible foldable regions are also stuck to the top.