build on node 18

[milahu]

fix #149580

some dependencies are blocking node 18
so lets "bump all the deps" and downgrade when needed

work in progress ...

• vscode/build
  • vscode/build/lib/nls.ts - handle position not found error
• downgrade to avoid "pure ESM" modules, to avoid dynamic import.
  store the downgraded versions in resolutions to protect them from yarn upgrade --latest (this is not working with yarn 1)
  • vscode: p-all
  • vscode/build: got, node-fetch
• use alternative to avoid "pure async" modules, to avoid API change to async
  • source-map-sync
• vscode/extensions/extension-editing
• todo: vscode/extensions/github-authentication
• build all packages with swc
  Explore "transpile only" build  #150025 (comment)
  for me, transpile-client-swc is 14x faster than transpile-client (40 sec vs 570 sec)
  fast-compile (swc) is 12x faster than compile (120 sec vs 1470 sec)
  • todo: does transpile-client-swc run twice?
    40 sec compilation + 40 sec transpile-client-swc = 80 sec
• rebase: update typescript in vscode/package.json (daily update)

typescript version error when directly running tsc

caused by calling typescript directly with npx tsc
fix: call typescript via gulp: npm run gulp compile etc

node_modules/@types/node/ts4.8/globals.d.ts:72:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.

72 declare var AbortSignal: {
               ~~~~~~~~~~~

  ../node_modules/typescript/lib/lib.webworker.d.ts:755:13
    755 declare var AbortSignal: {
                    ~~~~~~~~~~~
    'AbortSignal' was also declared here.

also seen in
https://issuehint.com/issue/microsoft/TypeScript/49283
microsoft/TypeScript#50948

fix? somehow disable @node/types for tsc

no fix: upgrade typescript to ^4.9.0-dev.20221005

not related? vscode-nls-dev@4.0.3 is using old versions of typescript

out of scope

• move away from yarn 1. alternatives: yarn 2, pnpm, npm
  • Migrate to pnpm or Yarn 3 (from Yarn 1) #162803
• move away from grunt? deprecated ...
• use a workspace for all packages, have only one lockfile, install faster

[milahu]

@microsoft-github-policy-service agree

[joaomoreno]

Migrating to Node 18 is neither something we're currently interested on (because the Electron we're currently based on is based on Node 16 itself), nor something we'd accept as an external contribution.

If you'd like to make a contribution to VS Code, I suggest reading our Contribution Guide. Thanks for understanding.