Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smoketests should not fail by bumping version in package.json #165132

Merged
merged 2 commits into from
Nov 1, 2022
+11 −10
Merged

smoketests should not fail by bumping version in package.json #165132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0f88d0
smoketests should not fail by bumping version in package.json
joaomoreno Nov 1, 2022
e1337e7
Merge branch 'main' into joao/secure-clam
joaomoreno Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions test/smoke/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,30 +263,31 @@ async function setupRepository(): Promise<void> {
async function ensureStableCode(): Promise<void> {
let stableCodePath = opts['stable-build'];
if (!stableCodePath) {
const { major, minor } = parseVersion(version!);
const majorMinorVersion = `${major}.${minor - 1}`;
const versionsReq = await retry(() => measureAndLog(() => fetch('https://update.code.visualstudio.com/api/releases/stable', { headers: { 'x-api-version': '2' } }), 'versionReq', logger), 1000, 20);
const current = parseVersion(version!);
const versionsReq = await retry(() => measureAndLog(() => fetch('https://update.code.visualstudio.com/api/releases/stable'), 'versionReq', logger), 1000, 20);

if (!versionsReq.ok) {
throw new Error('Could not fetch releases from update server');
}

const versions: { version: string }[] = await measureAndLog(() => versionsReq.json(), 'versionReq.json()', logger);
const prefix = `${majorMinorVersion}.`;
const previousVersion = versions.find(v => v.version.startsWith(prefix));
const versions: string[] = await measureAndLog(() => versionsReq.json(), 'versionReq.json()', logger);
const stableVersion = versions.find(raw => {
const version = parseVersion(raw);
return version.major < current.major || (version.major === current.major && version.minor < current.minor);
});

if (!previousVersion) {
throw new Error(`Could not find suitable stable version ${majorMinorVersion}`);
if (!stableVersion) {
throw new Error(`Could not find suitable stable version for ${version}`);
}

logger.log(`Found VS Code v${version}, downloading previous VS Code version ${previousVersion.version}...`);
logger.log(`Found VS Code v${version}, downloading previous VS Code version ${stableVersion}...`);

let lastProgressMessage: string | undefined = undefined;
let lastProgressReportedAt = 0;
const stableCodeDestination = path.join(testDataPath, 's');
const stableCodeExecutable = await retry(() => measureAndLog(() => vscodetest.download({
cachePath: stableCodeDestination,
version: previousVersion.version,
version: stableVersion,
extractSync: true,
reporter: {
report: report => {
Expand Down