-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the a11y terminal buffer dynamically #176413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Mar 7, 2023
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Outdated
Show resolved
Hide resolved
meganrogge
changed the title
update the a11y terminal buffer
update the a11y terminal buffer dynamically
Mar 7, 2023
onData
Tyriar
previously requested changes
Mar 8, 2023
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Show resolved
Hide resolved
meganrogge
commented
Mar 10, 2023
meganrogge
commented
Mar 10, 2023
meganrogge
force-pushed
the
merogge/update-buffer
branch
from
March 10, 2023 19:22
5189a32
to
e5d6d2a
Compare
Tyriar
previously requested changes
Mar 10, 2023
...rkbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminalAccessibleBuffer.ts
Outdated
Show resolved
Hide resolved
joyceerhl
approved these changes
Mar 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #172582