Set new default theme #179812
Merged
Set new default theme #179812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
reviewed
Apr 12, 2023
rzhao271
approved these changes
Apr 12, 2023
| await this._notificationService.notify({ | ||
| id: 'themeUpdatedNotification', | ||
| severity: Severity.Info, | ||
| message: localize({ key: 'themeUpdatedNotification', comment: ['{0} is the name of the new default theme'] }, "VS Code now ships with a new default theme '{0}'. We hope you like it. If not, you can switch back to the old theme or try one of the many other color themes available.", this._workbenchThemeService.getColorTheme().label), |
There was a problem hiding this comment.
@aeschli Wrong backtick...actually, that's fine it's the " should be `
There was a problem hiding this comment.
All is correct, right? No backtick needed here, localize does the substitution.
There was a problem hiding this comment.
Oops, you're right. Maybe this._workbenchThemeService.getColorTheme().label empty for some reason.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179688