testing: allow invalidateTestResults to take an array #183569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| checkProposedApiEnabled(extension, 'testInvalidateResults'); | ||
| const id = item ? TestId.fromExtHostTestItem(item, controllerId).toString() : controllerId; | ||
| return this.proxy.$markTestRetired(id); | ||
| for (const item of items instanceof Array ? items : [items]) { |
There was a problem hiding this comment.
I have been doing Array.isArray(arr) for ages. Is items instanceof Array better?
There was a problem hiding this comment.
Iirc Array.isArray(arr) works if the array is coming from a different origin. I generally like instanceof Array since it's simpler and more consistent 🤷
Probably the nice way to do this now would be checking if the object has [Symbol.iterator], but we don't yet take Iterables into any methods in extension host APIs.
TylerLeonhardt
approved these changes
May 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #134970