Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize EnvironmentVariableMutatorOptions API #191082

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Finalize EnvironmentVariableMutatorOptions API #191082

merged 4 commits into from
Aug 24, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 23, 2023

Fixes #179476

@Tyriar Tyriar added this to the August 2023 milestone Aug 23, 2023
@Tyriar Tyriar requested a review from karrtikr August 23, 2023 14:55
@Tyriar Tyriar self-assigned this Aug 23, 2023
@Tyriar Tyriar enabled auto-merge August 23, 2023 14:55
karrtikr
karrtikr reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing

src/vs/workbench/api/common/extHostTerminalService.ts Show resolved Hide resolved
@Tyriar Tyriar requested a review from karrtikr August 24, 2023 22:35
@Tyriar Tyriar merged commit d0d5949 into main Aug 24, 2023
6 checks passed
@Tyriar Tyriar deleted the tyriar/finalize_179476 branch August 24, 2023 22:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karrtikr karrtikr karrtikr approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

Allow EnvironmentVariableCollection API to apply changes via shell integration
2 participants
@Tyriar @karrtikr