Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NLS without AMD loader #214588

Merged
merged 101 commits into from
Jun 28, 2024
Merged

Implement NLS without AMD loader #214588

merged 101 commits into from
Jun 28, 2024

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jun 7, 2024

fix #212542

@bpasero bpasero self-assigned this Jun 7, 2024
@bpasero bpasero changed the title ben/wip Exploration: NLS without AMD loader Jun 10, 2024
@bpasero bpasero added this to the July 2024 milestone Jun 25, 2024
@bpasero bpasero marked this pull request as ready for review June 25, 2024 06:19
@bpasero bpasero changed the title Exploration: NLS without AMD loader Implement NLS without AMD loader Jun 25, 2024
@bpasero bpasero removed the request for review from joaomoreno June 28, 2024 09:36
@bpasero bpasero enabled auto-merge (squash) June 28, 2024 09:36
@joaomoreno joaomoreno self-requested a review June 28, 2024 09:48
@joaomoreno
Copy link
Member

it's big

@bpasero bpasero merged commit f6f90e0 into main Jun 28, 2024
14 of 19 checks passed
@bpasero bpasero deleted the ben/nls-without-plugin branch June 28, 2024 09:55
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this pull request Jul 10, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NLS: decouple from loader (helps for ESM)
2 participants