-
Notifications
You must be signed in to change notification settings - Fork 36.5k
Add support for GH Custom Agents #278251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GH Custom Agents #278251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for GitHub Custom Agents by integrating an API to fetch custom agent configurations from GitHub Copilot's backend. The changes introduce a new service to fetch custom agents from an external API and integrate them into VS Code's chat mode system.
Key changes:
- Introduces
CustomAgentsServiceto fetch custom agents from GitHub Copilot API - Integrates API-fetched agents into the existing
ChatModeServicealongside file-based custom modes - Adds product configuration for the custom agents API endpoint
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/customAgents.ts | New service for fetching custom agents from GitHub Copilot API with hardcoded repository detection |
| src/vs/workbench/contrib/chat/common/chatModes.ts | Integrates API-fetched custom agents into the chat mode system with a hardcoded test agent |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Registers the new CustomAgentsService as a singleton |
| src/vs/base/common/product.ts | Adds optional customAgentsUrl field to product configuration |
| product.json | Configures the GitHub Copilot custom agents API endpoint URL and reformats provider scopes |
addcf47 to
6dad19a
Compare
src/vs/workbench/contrib/chat/common/promptSyntax/service/promptsServiceImpl.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/common/promptSyntax/service/promptsServiceImpl.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/common/promptSyntax/service/promptsServiceImpl.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/common/promptSyntax/service/promptsServiceImpl.ts
Outdated
Show resolved
Hide resolved
0daacee to
fabc1c2
Compare
|
Looks great! |
src/vs/workbench/contrib/chat/common/promptSyntax/service/promptsServiceImpl.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/common/promptSyntax/service/promptsServiceImpl.ts
Show resolved
Hide resolved
| /** | ||
| * Options for querying custom agents. | ||
| */ | ||
| export interface CustomAgentQueryOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this currently used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is technically unused at the moment, but I wanted to keep an options bundle as a positional arg in case we need it later - should I just remove this?
Related: microsoft/vscode-copilot-chat#2118