Skip to content

Conversation

@pwang347
Copy link
Member

@pwang347 pwang347 commented Nov 19, 2025

Copilot AI review requested due to automatic review settings November 19, 2025 01:30
Copilot finished reviewing on behalf of pwang347 November 19, 2025 01:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for GitHub Custom Agents by integrating an API to fetch custom agent configurations from GitHub Copilot's backend. The changes introduce a new service to fetch custom agents from an external API and integrate them into VS Code's chat mode system.

Key changes:

  • Introduces CustomAgentsService to fetch custom agents from GitHub Copilot API
  • Integrates API-fetched agents into the existing ChatModeService alongside file-based custom modes
  • Adds product configuration for the custom agents API endpoint

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/vs/workbench/contrib/chat/common/customAgents.ts New service for fetching custom agents from GitHub Copilot API with hardcoded repository detection
src/vs/workbench/contrib/chat/common/chatModes.ts Integrates API-fetched custom agents into the chat mode system with a hardcoded test agent
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Registers the new CustomAgentsService as a singleton
src/vs/base/common/product.ts Adds optional customAgentsUrl field to product configuration
product.json Configures the GitHub Copilot custom agents API endpoint URL and reformats provider scopes

@pwang347 pwang347 force-pushed the pawang/ghCustomAgents branch from 0daacee to fabc1c2 Compare November 26, 2025 01:11
@pwang347 pwang347 marked this pull request as ready for review November 26, 2025 01:11
@vs-code-engineering vs-code-engineering bot added this to the November 2025 milestone Nov 26, 2025
aeschli
aeschli previously approved these changes Nov 26, 2025
@aeschli
Copy link
Contributor

aeschli commented Nov 26, 2025

Looks great!

/**
* Options for querying custom agents.
*/
export interface CustomAgentQueryOptions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this currently used?

Copy link
Member Author

@pwang347 pwang347 Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is technically unused at the moment, but I wanted to keep an options bundle as a positional arg in case we need it later - should I just remove this?

@pwang347 pwang347 merged commit d2865eb into main Nov 26, 2025
28 checks passed
@pwang347 pwang347 deleted the pawang/ghCustomAgents branch November 26, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants