Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TextEditorOptions declaration - fixes #2797 #2935

Merged
merged 1 commit into from
Feb 19, 2016
Merged

fix TextEditorOptions declaration - fixes #2797 #2935

merged 1 commit into from
Feb 19, 2016

Conversation

SamVerschueren
Copy link
Contributor

It is possible to provide the value auto to either one of the properties. So the declaration is not entirely correct.

This fixes #2797

// @alexandrudima

@msftclas
Copy link

Hi @SamVerschueren, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@SamVerschueren
Copy link
Contributor Author

Not sure if the documentation should be changed?

When pressing Tab insert [n](#TextEditorOptions.tabSize) spaces or `auto`-calculate.

@alexdima alexdima self-assigned this Feb 12, 2016
@egamma egamma added this to the Feb 2016 milestone Feb 19, 2016
alexdima added a commit that referenced this pull request Feb 19, 2016
fix TextEditorOptions declaration - fixes #2797
@alexdima alexdima merged commit 9dea2c3 into microsoft:master Feb 19, 2016
@alexdima
Copy link
Member

Thank you!

@SamVerschueren
Copy link
Contributor Author

Awesome. Thank you very much!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing TextEditor.options issues
4 participants