diff --git a/build/tfs/darwin/build.sh b/build/tfs/darwin/build.sh index e342401b34e59..80676602f2efa 100755 --- a/build/tfs/darwin/build.sh +++ b/build/tfs/darwin/build.sh @@ -25,8 +25,8 @@ step "Install distro dependencies" \ step "Build minified & upload source maps" \ npm run gulp -- --max_old_space_size=4096 vscode-darwin-min upload-vscode-sourcemaps -step "Create loader snapshot" - node build/lib/snapshotLoader.js +# step "Create loader snapshot" +# node build/lib/snapshotLoader.js step "Run unit tests" \ ./scripts/test.sh --build --reporter dot diff --git a/build/tfs/linux/build.sh b/build/tfs/linux/build.sh index 64101890aad47..541130d2b5069 100755 --- a/build/tfs/linux/build.sh +++ b/build/tfs/linux/build.sh @@ -30,8 +30,8 @@ step "Install distro dependencies" \ step "Build minified" \ npm run gulp -- --max_old_space_size=4096 "vscode-linux-$ARCH-min" -step "Create loader snapshot" - node build/lib/snapshotLoader.js --arch=$ARCH +# step "Create loader snapshot" +# node build/lib/snapshotLoader.js --arch=$ARCH step "Run unit tests" \ ./scripts/test.sh --build --reporter dot diff --git a/build/tfs/win32/1_build.ps1 b/build/tfs/win32/1_build.ps1 index ea31fd31b0476..c27b05caeaffa 100644 --- a/build/tfs/win32/1_build.ps1 +++ b/build/tfs/win32/1_build.ps1 @@ -36,9 +36,9 @@ step "Build minified" { exec { & npm run gulp -- --max_old_space_size=4096 "vscode-win32-$global:arch-min" } } -step "Create loader snapshot" { - exec { & node build\lib\snapshotLoader.js --arch=$global:arch } -} +# step "Create loader snapshot" { +# exec { & node build\lib\snapshotLoader.js --arch=$global:arch } +# } step "Run unit tests" { exec { & .\scripts\test.bat --build --reporter dot } diff --git a/package.json b/package.json index 174086e531852..c22c7d255b2c0 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "code-oss-dev", "version": "1.16.0", - "electronVersion": "1.6.6", + "electronVersion": "1.7.4", "distro": "724097db097bfde7796fcca70aaac83ba80a95f8", "author": { "name": "Microsoft Corporation" @@ -59,7 +59,7 @@ "cson-parser": "^1.3.3", "debounce": "^1.0.0", "documentdb": "^1.5.1", - "electron-mksnapshot": "1.6.0", + "electron-mksnapshot": "~1.7.0", "eslint": "^3.4.0", "event-stream": "^3.1.7", "express": "^4.13.1", @@ -129,4 +129,4 @@ "windows-mutex": "^0.2.0", "fsevents": "0.3.8" } -} \ No newline at end of file +} diff --git a/scripts/test.bat b/scripts/test.bat index 6ac41fcc36e6a..48ee90d108f02 100644 --- a/scripts/test.bat +++ b/scripts/test.bat @@ -26,4 +26,10 @@ if not "%INSTALLEDVERSION%" == "%DESIREDVERSION%" node .\node_modules\gulp\bin\g popd endlocal + +:: app.exit(0) is exiting with code 255 in Electron 1.7.4. +:: See https://github.com/Microsoft/vscode/issues/28582 +echo errorlevel: %errorlevel% +if %errorlevel% == 255 set errorlevel=0 + exit /b %errorlevel%