path completion for css. fix #45235 #45788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeschli
reviewed
Mar 14, 2018
| @@ -0,0 +1,79 @@ | |||
| /*--------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
only copy the functions you need
|
Yes, agree, the more API we have, the harder it is to maintain this. Happy to go with any proposal that requires less API. Alternative could be to give the CSS service a |
octref
force-pushed
the
octref/pathCompletion
branch
from
0ab2398
to
0ae6c19
Compare
octref
changed the title
aeschli
reviewed
Mar 19, 2018
| import { TextDocument, TextEdit } from 'vscode-languageserver-types'; | ||
| import { mergeSort } from './arrays'; | ||
|
|
||
| export function applyEdits(document: TextDocument, edits: TextEdit[]): string { |
There was a problem hiding this comment.
The latest vscode-languageserver-types now offers
TextDocument.applyEdits
| items: [] | ||
| }; | ||
| cssLS.setCompletionParticipants([getPathCompletionParticipant(document, workspaceFolders, pathCompletionList)]); | ||
| const result = getLanguageService(document).doComplete(document, textDocumentPosition.position, stylesheets.get(document))!; /* TODO: remove ! once LS has null annotations */ |
| { label: 'about/', resultText: `html { background-image: url('../about/')` }, | ||
| { label: 'index.html', resultText: `html { background-image: url('../index.html')` }, | ||
| { label: 'src/', resultText: `html { background-image: url('../src/')` } | ||
| ] |
There was a problem hiding this comment.
Please also test:
url('../a|')
url('../a|b')
url(a|)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To go together with microsoft/vscode-css-languageservice#76
Questions:
onCssURILiteralValuein CSS Lang Service? I imagine this would be no use to anything else other than path completion. Since one of March's task issimplify consumption of our language servers, I feel adding all these API surface area is going to make the consumption of LS harder.