Support debugging process from the process explorer #63953
Conversation
| @@ -133,7 +133,11 @@ export class StartAction extends AbstractDebugAction { | |||
| this.toDispose.push(this.contextService.onDidChangeWorkbenchState(() => this.updateEnablement())); | |||
| } | |||
|
|
|||
| public run(): Thenable<any> { | |||
| public run(config?: string | IConfig): Thenable<any> { | |||
There was a problem hiding this comment.
@isidorn fyi on this change in the PR impacting debug action
There was a problem hiding this comment.
@RMacfarlane not the nicest. But fine for me. Why do you have string | IConfig, when you always pass an IConfig as far as I understand?
There was a problem hiding this comment.
Also please add a comment for the use case here. So I do not accidently delete this code later
There was a problem hiding this comment.
I updated it to be only IConfig and added a note
src/vs/workbench/common/actions.ts
Outdated
| @@ -110,7 +110,11 @@ Registry.add(Extensions.WorkbenchActions, new class implements IWorkbenchActionR | |||
|
|
|||
| const from = args && args.from || 'keybinding'; | |||
|
|
|||
| return Promise.resolve(actionInstance.run(undefined, { from })).then(() => { | |||
| if (args) { | |||
There was a problem hiding this comment.
@RMacfarlane the change looks good to me except for this piece that scares me. Are we sure we are not sending arbitrary data to all actions that get executed that might expect something else here? There is only one action where we need this for (Start Debug) but for any action that is triggered we now pass the args on. This has the potential of breaking badly if an action is not ready for that.
There was a problem hiding this comment.
Yeah, this was the code I wasn't sure about. Since only Start Debug needs the args passed on, I reverted this change and added separate code for registering that command
There was a problem hiding this comment.
@RMacfarlane yeah better, you seem to have a weird strictNull check change in this PR though.
RMacfarlane
force-pushed
the
rmacfarlane/debug-process
branch
from
8ea1f67
to
c9ff8b6
Compare
Adds a 'Debug' context menu item for processes that can be attached to in the process explorer. #63147
The issue service that communicates with the process explorer window lives in the main process, and the debug service is only in the renderer process. To start debugging, the issue service sends a
vscode:runActionmessage to the renderer with the workbench debug start action id. To pass the debug config, I tweaked thevscode:runActionlistener to pass through arguments to executeCommand. I also had to make a change to the workbench command handler to pass the argument, let me know if this looks reasonable.