Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[json] semantic selection #67261

Merged
merged 2 commits into from
Jan 28, 2019
Merged

[json] semantic selection #67261

merged 2 commits into from
Jan 28, 2019

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Jan 28, 2019 •
edited
Loading

fixes #67232

@aeschli
Copy link
Contributor Author

aeschli commented Jan 28, 2019

@octref See changes to cssMain and htmlMain...

@aeschli
Copy link
Contributor Author

aeschli commented Jan 28, 2019

@octref I also remove the copies of the vscode.propose.d.ts

octref
octref approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine for me, thanks!

@aeschli aeschli merged commit 7ff3173 into master Jan 28, 2019
@aeschli aeschli added this to the December/January 2019 milestone Jan 28, 2019
@aeschli aeschli deleted the aeschli/json-semantic-selection branch February 5, 2019 19:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@octref octref octref approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
December/January 2019
Development

Successfully merging this pull request may close these issues.

[json] support semantic selection
2 participants
@aeschli @octref