Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer: Use compressed tree widget #83978

Merged
merged 16 commits into from
Nov 6, 2019
Merged

Conversation

joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Nov 5, 2019

Implements #41627

TODO

  • Creating a new top-level file/folder seems to erase compression data
  • Expose compressionEnabled tree/model option
  • Expose this to the user via a explorer.compressSingleChildFolders setting

@joaomoreno joaomoreno self-assigned this Nov 5, 2019
@joaomoreno joaomoreno added this to the November 2019 milestone Nov 5, 2019
@joaomoreno joaomoreno added file-explorer Explorer widget issues tree-widget Tree widget issues labels Nov 5, 2019
@joaomoreno
Copy link
Member Author

OK merging this barebones implementation, including a explorer.compressSingleChildFolders setting:

Peek 2019-11-06 16-06

@isidorn Here are next steps, if you plan on advancing this:

  • Handle each folder in a compressed tree node separately. One should be able to hover the folder names and drag them or context menu click them and get the actions only for that folder. One should also be able to drop files selectively on each folder.
  • The explorer.compressSingleChildFolders setting could be a resource setting and be scoped per folder, ie each root folder could have different compression settings, for example. Compression can only be enabled/disabled globally per tree right now. But the isIncompressible method will give you finer level of control allowing you to implement this.

@joaomoreno joaomoreno merged commit 619c082 into master Nov 6, 2019
@joaomoreno joaomoreno deleted the joao/explorer-compressed-tree branch November 6, 2019 15:11
@isidorn
Copy link
Contributor

isidorn commented Nov 12, 2019

Fancy! Great work. I am still buried in notifications, but we can sync tomorrow / thursday so we talk about how to split up the rest of the work. Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
file-explorer Explorer widget issues tree-widget Tree widget issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants