Support ViewPaneContainer in Panel #87191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandy081
requested changes
Dec 17, 2019
src/vs/workbench/browser/panel.ts
Outdated
|
|
||
| export abstract class Panel extends Composite implements IPanel { } | ||
|
|
||
| export abstract class PanelV2 extends PaneComposite implements IPanel { } |
There was a problem hiding this comment.
How about calling this PaneCompositePanel ?
| @@ -344,7 +345,8 @@ export class ViewPaneContainer extends Component implements IViewPaneContainer { | |||
| } | |||
|
|
|||
| getTitle(): string { | |||
| let title = Registry.as<ViewletRegistry>(Extensions.Viewlets).getViewlet(this.getId()).name; | |||
| const composite = Registry.as<ViewletRegistry>(ViewletExtensions.Viewlets).getViewlet(this.getId()) || Registry.as<PanelRegistry>(PanelExtensions.Panels).getPanel(this.getId()); | |||
There was a problem hiding this comment.
Looks like ViewContainer should support name property. Can you please create a follow up item for this?
sandy081
approved these changes
Dec 17, 2019
|
Few comments as mentioned above, otherwise LGTM. Please merge it after above feedback is taken care of. |
13 tasks
40 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.