Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout - move restore logic into layout itself #99972

Merged
merged 2 commits into from
Jun 13, 2020
Merged

layout - move restore logic into layout itself #99972

merged 2 commits into from
Jun 13, 2020
+142 −153

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jun 12, 2020

I feel this belongs into layout.

//cc @sandy081

@bpasero bpasero added this to the June 2020 milestone Jun 12, 2020
@bpasero bpasero requested review from eamodio and sbatten June 12, 2020 10:05
@bpasero bpasero self-assigned this Jun 12, 2020
@bpasero bpasero mentioned this pull request Jun 12, 2020
Closed
sbatten
sbatten approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@sbatten sbatten left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i buy it, did not test but review looks like mostly a copy cut paste

eamodio
eamodio approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bpasero bpasero merged commit 2e9edc3 into master Jun 13, 2020
@bpasero bpasero deleted the ben/layout-restore branch June 13, 2020 06:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eamodio eamodio eamodio approved these changes

@sbatten sbatten sbatten approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
June 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@bpasero @eamodio @sbatten