From 9cc06c60e267978993693445e1ea3e69c705aff9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Amaury=20Lev=C3=A9?= <amauryleve@microsoft.com>
Date: Mon, 7 Feb 2022 18:14:22 +0100
Subject: [PATCH] Enable TreatWarningsAsErrors only on CI

We raised the severity of some rules from message to warning to ensure they are followed in the team but because of the `TreatWarningsAsErrors` we end up with some "boring" dev cycles where we are forced to cleanup usings etc while we iterate. The idea is to keep warnings locally to not slow us down but still fail in PRs so that we can keep styling consistency.
---
 scripts/build/TestPlatform.Settings.targets | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/build/TestPlatform.Settings.targets b/scripts/build/TestPlatform.Settings.targets
index 2539dc660b..b3b69c606b 100644
--- a/scripts/build/TestPlatform.Settings.targets
+++ b/scripts/build/TestPlatform.Settings.targets
@@ -20,7 +20,9 @@
          serialization. This is also defined in build script. -->
     <AssemblyVersion Condition="'$(AssemblyVersion)' == ''">15.0.0</AssemblyVersion>
 
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <!-- Treat warnings as errors only on CI to prevent painful development process because of unused usings... -->
+    <TreatWarningsAsErrors Condition="'$(CIBuild)' == 'true'">true</TreatWarningsAsErrors>
+
     <PublicSign Condition="'$(CIBuild)' == '' or '$(CIBuild)' == 'false'">true</PublicSign>
     <DelaySign Condition="'$(CIBuild)' == 'true'">true</DelaySign>
     <!--<GenerateDocumentationFile>true</GenerateDocumentationFile>-->