From 45bc738679e83e8d640c72c25cd4d6c10d3e2ab8 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 6 Mar 2024 15:26:48 +0000 Subject: [PATCH 1/7] Make VSTest repo buildable in VMR unified-build --- Directory.Build.props | 2 +- Directory.Build.targets | 4 ++-- eng/AfterSolutionBuild.targets | 13 +++++++------ eng/Analyzers.props | 4 ++-- eng/{SourceBuild.props => DotNetBuild.props} | 0 eng/Versions.props | 2 +- .../DumpMinitool.arm64/DumpMinitool.arm64.csproj | 2 +- .../DumpMinitool.x86/DumpMinitool.x86.csproj | 2 +- src/DataCollectors/DumpMinitool/DumpMinitool.csproj | 2 +- .../Microsoft.TestPlatform.AdapterUtilities.csproj | 4 ++-- .../Microsoft.TestPlatform.Build.csproj | 6 +++--- ...estPlatform.Extensions.BlameDataCollector.csproj | 2 +- ...crosoft.TestPlatform.Extensions.TrxLogger.csproj | 2 +- .../Microsoft.TestPlatform.ObjectModel.csproj | 2 +- .../Microsoft.TestPlatform.TestHostProvider.csproj | 2 +- ...stPlatform.VsTestConsole.TranslationLayer.csproj | 2 +- .../Microsoft.CodeCoverage.csproj | 2 +- .../Microsoft.NET.Test.Sdk.csproj | 2 +- .../Microsoft.TestPlatform.CLI.csproj | 12 ++++++------ .../Microsoft.TestPlatform.Internal.Uwp.csproj | 2 +- .../Microsoft.TestPlatform.Portable.csproj | 2 +- .../Microsoft.TestPlatform.TestHost.csproj | 2 +- .../Microsoft.TestPlatform.csproj | 2 +- src/testhost.arm64/testhost.arm64.csproj | 4 ++-- src/testhost.x86/testhost.x86.csproj | 4 ++-- src/testhost/testhost.csproj | 4 ++-- 26 files changed, 44 insertions(+), 43 deletions(-) rename eng/{SourceBuild.props => DotNetBuild.props} (100%) diff --git a/Directory.Build.props b/Directory.Build.props index 08a99ab45b..1d8854a6ba 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -78,7 +78,7 @@ MIT false - $(DefineConstants);DOTNET_BUILD_FROM_SOURCE + $(DefineConstants);DOTNET_BUILD_FROM_SOURCE true embedded diff --git a/Directory.Build.targets b/Directory.Build.targets index aca11f2f1a..f3728cca7a 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -8,14 +8,14 @@ necessary as the output of this leg is used in other CI source build legs. Those could be targeting NetCurrent or NetPrevious hence we must produce both. --> - + $(NetPrevious);$(NetCurrent) - + $(NetCurrent) diff --git a/eng/AfterSolutionBuild.targets b/eng/AfterSolutionBuild.targets index effc6940a2..c10d1b34c7 100644 --- a/eng/AfterSolutionBuild.targets +++ b/eng/AfterSolutionBuild.targets @@ -8,13 +8,14 @@ - - + diff --git a/eng/Analyzers.props b/eng/Analyzers.props index 1fe24d2467..f86467ccd7 100644 --- a/eng/Analyzers.props +++ b/eng/Analyzers.props @@ -3,7 +3,7 @@ Include PublicApi analyzers into all projects that are in our src directory. Use relative path between the project and the root to avoid including the analyzer if the path above the root contains 'src' (e.g. C:\src\vstest). --> - + all runtime; build; native; contentfiles; analyzers; buildtransitive @@ -11,7 +11,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/eng/SourceBuild.props b/eng/DotNetBuild.props similarity index 100% rename from eng/SourceBuild.props rename to eng/DotNetBuild.props diff --git a/eng/Versions.props b/eng/Versions.props index 86c617bf93..f272ea3418 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -47,7 +47,7 @@ 16.3.42 17.4.2124 13.0.1 - 13.0.3 + 13.0.3 1.5.0 4.5.0 4.5.5 diff --git a/src/DataCollectors/DumpMinitool.arm64/DumpMinitool.arm64.csproj b/src/DataCollectors/DumpMinitool.arm64/DumpMinitool.arm64.csproj index 713c464a0f..1efec3f46e 100644 --- a/src/DataCollectors/DumpMinitool.arm64/DumpMinitool.arm64.csproj +++ b/src/DataCollectors/DumpMinitool.arm64/DumpMinitool.arm64.csproj @@ -6,7 +6,7 @@ false Exe false - win10-arm64 + win10-arm64 AnyCPU diff --git a/src/DataCollectors/DumpMinitool.x86/DumpMinitool.x86.csproj b/src/DataCollectors/DumpMinitool.x86/DumpMinitool.x86.csproj index 19f665286d..9c77b43a39 100644 --- a/src/DataCollectors/DumpMinitool.x86/DumpMinitool.x86.csproj +++ b/src/DataCollectors/DumpMinitool.x86/DumpMinitool.x86.csproj @@ -7,7 +7,7 @@ true Exe false - win7-x86 + win7-x86 false true diff --git a/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj b/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj index 2cd96cddda..178e278fa7 100644 --- a/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj +++ b/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj @@ -11,9 +11,9 @@ true - Microsoft.TestPlatform.Build.nuspec - Microsoft.TestPlatform.Build.sourcebuild.nuspec - Microsoft.TestPlatform.Build.sourcebuild.product.nuspec + Microsoft.TestPlatform.Build.nuspec + Microsoft.TestPlatform.Build.sourcebuild.nuspec + Microsoft.TestPlatform.Build.sourcebuild.product.nuspec $(OutputPath) Microsoft.TestPlatform.Build vstest visual-studio unittest testplatform mstest microsoft test testing diff --git a/src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Microsoft.TestPlatform.Extensions.BlameDataCollector.csproj b/src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Microsoft.TestPlatform.Extensions.BlameDataCollector.csproj index f90dc4e6fe..c337afa54b 100644 --- a/src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Microsoft.TestPlatform.Extensions.BlameDataCollector.csproj +++ b/src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Microsoft.TestPlatform.Extensions.BlameDataCollector.csproj @@ -32,7 +32,7 @@ - + diff --git a/src/Microsoft.TestPlatform.Extensions.TrxLogger/Microsoft.TestPlatform.Extensions.TrxLogger.csproj b/src/Microsoft.TestPlatform.Extensions.TrxLogger/Microsoft.TestPlatform.Extensions.TrxLogger.csproj index 9a70badab6..cbe38fd2ab 100644 --- a/src/Microsoft.TestPlatform.Extensions.TrxLogger/Microsoft.TestPlatform.Extensions.TrxLogger.csproj +++ b/src/Microsoft.TestPlatform.Extensions.TrxLogger/Microsoft.TestPlatform.Extensions.TrxLogger.csproj @@ -8,7 +8,7 @@ - true + true Microsoft.TestPlatform.Extensions.TrxLogger.nuspec $(OutputPath) Microsoft.TestPlatform.Extensions.TrxLogger diff --git a/src/Microsoft.TestPlatform.ObjectModel/Microsoft.TestPlatform.ObjectModel.csproj b/src/Microsoft.TestPlatform.ObjectModel/Microsoft.TestPlatform.ObjectModel.csproj index 0fb981d962..9278611cbd 100644 --- a/src/Microsoft.TestPlatform.ObjectModel/Microsoft.TestPlatform.ObjectModel.csproj +++ b/src/Microsoft.TestPlatform.ObjectModel/Microsoft.TestPlatform.ObjectModel.csproj @@ -9,7 +9,7 @@ - true + true Microsoft.TestPlatform.ObjectModel.nuspec $(OutputPath) Microsoft.TestPlatform.ObjectModel diff --git a/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj b/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj index 42519a6811..8191a31a24 100644 --- a/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj +++ b/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj @@ -26,7 +26,7 @@ - + diff --git a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Microsoft.TestPlatform.VsTestConsole.TranslationLayer.csproj b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Microsoft.TestPlatform.VsTestConsole.TranslationLayer.csproj index b235169a90..a9278a3e86 100644 --- a/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Microsoft.TestPlatform.VsTestConsole.TranslationLayer.csproj +++ b/src/Microsoft.TestPlatform.VsTestConsole.TranslationLayer/Microsoft.TestPlatform.VsTestConsole.TranslationLayer.csproj @@ -12,7 +12,7 @@ - true + true Microsoft.TestPlatform.VsTestConsole.TranslationLayer.nuspec $(OutputPath) Microsoft.TestPlatform.TranslationLayer diff --git a/src/package/Microsoft.CodeCoverage/Microsoft.CodeCoverage.csproj b/src/package/Microsoft.CodeCoverage/Microsoft.CodeCoverage.csproj index 7982c1c9c4..961ffc151c 100644 --- a/src/package/Microsoft.CodeCoverage/Microsoft.CodeCoverage.csproj +++ b/src/package/Microsoft.CodeCoverage/Microsoft.CodeCoverage.csproj @@ -4,7 +4,7 @@ - true + true Microsoft.CodeCoverage.nuspec $(OutputPath) Microsoft.CodeCoverage diff --git a/src/package/Microsoft.NET.Test.Sdk/Microsoft.NET.Test.Sdk.csproj b/src/package/Microsoft.NET.Test.Sdk/Microsoft.NET.Test.Sdk.csproj index c799309c56..1764ba0ef3 100644 --- a/src/package/Microsoft.NET.Test.Sdk/Microsoft.NET.Test.Sdk.csproj +++ b/src/package/Microsoft.NET.Test.Sdk/Microsoft.NET.Test.Sdk.csproj @@ -4,7 +4,7 @@ - true + true Microsoft.NET.Test.Sdk.nuspec $(OutputPath) Microsoft.NET.Test.Sdk diff --git a/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj b/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj index f80380cb74..58512d2fc5 100644 --- a/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj +++ b/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj @@ -4,9 +4,9 @@ - Microsoft.TestPlatform.CLI.nuspec - Microsoft.TestPlatform.CLI.sourcebuild.nuspec - Microsoft.TestPlatform.CLI.sourcebuild.product.nuspec + Microsoft.TestPlatform.CLI.nuspec + Microsoft.TestPlatform.CLI.sourcebuild.nuspec + Microsoft.TestPlatform.CLI.sourcebuild.product.nuspec true false @@ -53,7 +53,7 @@ - + @@ -61,7 +61,7 @@ - + @@ -81,7 +81,7 @@ - + diff --git a/src/package/Microsoft.TestPlatform.Internal.Uwp/Microsoft.TestPlatform.Internal.Uwp.csproj b/src/package/Microsoft.TestPlatform.Internal.Uwp/Microsoft.TestPlatform.Internal.Uwp.csproj index 6bb50b9764..bf5d4d1ad6 100644 --- a/src/package/Microsoft.TestPlatform.Internal.Uwp/Microsoft.TestPlatform.Internal.Uwp.csproj +++ b/src/package/Microsoft.TestPlatform.Internal.Uwp/Microsoft.TestPlatform.Internal.Uwp.csproj @@ -4,7 +4,7 @@ - true + true false Microsoft.TestPlatform.Internal.Uwp.nuspec diff --git a/src/package/Microsoft.TestPlatform.Portable/Microsoft.TestPlatform.Portable.csproj b/src/package/Microsoft.TestPlatform.Portable/Microsoft.TestPlatform.Portable.csproj index 73d7b35d15..cb61e64592 100644 --- a/src/package/Microsoft.TestPlatform.Portable/Microsoft.TestPlatform.Portable.csproj +++ b/src/package/Microsoft.TestPlatform.Portable/Microsoft.TestPlatform.Portable.csproj @@ -15,7 +15,7 @@ - true + true Microsoft.TestPlatform.Portable.nuspec $(OutputPath) Microsoft.TestPlatform.Portable diff --git a/src/package/Microsoft.TestPlatform.TestHost/Microsoft.TestPlatform.TestHost.csproj b/src/package/Microsoft.TestPlatform.TestHost/Microsoft.TestPlatform.TestHost.csproj index 076a5ab5c5..d1c996a385 100644 --- a/src/package/Microsoft.TestPlatform.TestHost/Microsoft.TestPlatform.TestHost.csproj +++ b/src/package/Microsoft.TestPlatform.TestHost/Microsoft.TestPlatform.TestHost.csproj @@ -4,7 +4,7 @@ - true + true Microsoft.TestPlatform.TestHost.nuspec $(OutputPath) Microsoft.TestPlatform.TestHost diff --git a/src/package/Microsoft.TestPlatform/Microsoft.TestPlatform.csproj b/src/package/Microsoft.TestPlatform/Microsoft.TestPlatform.csproj index d1200201ac..c1cdb5a24b 100644 --- a/src/package/Microsoft.TestPlatform/Microsoft.TestPlatform.csproj +++ b/src/package/Microsoft.TestPlatform/Microsoft.TestPlatform.csproj @@ -14,7 +14,7 @@ - true + true Microsoft.TestPlatform.nuspec $(OutputPath) Microsoft.TestPlatform diff --git a/src/testhost.arm64/testhost.arm64.csproj b/src/testhost.arm64/testhost.arm64.csproj index f062eae78c..095fe3ca5d 100644 --- a/src/testhost.arm64/testhost.arm64.csproj +++ b/src/testhost.arm64/testhost.arm64.csproj @@ -16,7 +16,7 @@ app.manifest - win10-arm64 + win10-arm64 false $(AssemblyName.Replace('.arm64', '')).$(TargetFramework).arm64 @@ -37,7 +37,7 @@ - + diff --git a/src/testhost.x86/testhost.x86.csproj b/src/testhost.x86/testhost.x86.csproj index 841fee658a..1a7de790bc 100644 --- a/src/testhost.x86/testhost.x86.csproj +++ b/src/testhost.x86/testhost.x86.csproj @@ -12,7 +12,7 @@ testhost.x86 net7.0;$(NetCoreAppMinimum);$(NetFrameworkMinimum);net47;net471;net472;net48 AnyCPU - win7-x86 + win7-x86 true Exe false @@ -44,7 +44,7 @@ - + diff --git a/src/testhost/testhost.csproj b/src/testhost/testhost.csproj index d03cdcb31b..f3f4b9b979 100644 --- a/src/testhost/testhost.csproj +++ b/src/testhost/testhost.csproj @@ -16,7 +16,7 @@ app.manifest - win7-x64 + win7-x64 false $(AssemblyName).$(TargetFramework) @@ -37,7 +37,7 @@ - + From 3d88c28e93617926331cf19fefefd929486eeff7 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 6 Mar 2024 16:41:12 +0100 Subject: [PATCH 2/7] Update Directory.Build.targets Co-authored-by: Matt Mitchell --- Directory.Build.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Directory.Build.targets b/Directory.Build.targets index f3728cca7a..f22123195b 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -8,7 +8,7 @@ necessary as the output of this leg is used in other CI source build legs. Those could be targeting NetCurrent or NetPrevious hence we must produce both. --> - + $(NetPrevious);$(NetCurrent) From 4826d45d9546d091b0fc3efced32689f9b216190 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 6 Mar 2024 16:41:18 +0100 Subject: [PATCH 3/7] Update Directory.Build.targets Co-authored-by: Matt Mitchell --- Directory.Build.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Directory.Build.targets b/Directory.Build.targets index f22123195b..d38dee58b5 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -15,7 +15,7 @@ - + $(NetCurrent) From d2976cc8c0cd001448a5d1bdc4044005227416f1 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 6 Mar 2024 16:41:24 +0100 Subject: [PATCH 4/7] Update src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj Co-authored-by: Matt Mitchell --- .../Microsoft.TestPlatform.Build.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj b/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj index 178e278fa7..08bf235f13 100644 --- a/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj +++ b/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj @@ -12,7 +12,7 @@ true Microsoft.TestPlatform.Build.nuspec - Microsoft.TestPlatform.Build.sourcebuild.nuspec + Microsoft.TestPlatform.Build.sourcebuild.nuspec Microsoft.TestPlatform.Build.sourcebuild.product.nuspec $(OutputPath) Microsoft.TestPlatform.Build From 86079ed004197c8d33484f34781f55a1d5191db4 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 6 Mar 2024 16:41:29 +0100 Subject: [PATCH 5/7] Update src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj Co-authored-by: Matt Mitchell --- .../Microsoft.TestPlatform.Build.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj b/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj index 08bf235f13..0fdd27966b 100644 --- a/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj +++ b/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj @@ -13,7 +13,7 @@ true Microsoft.TestPlatform.Build.nuspec Microsoft.TestPlatform.Build.sourcebuild.nuspec - Microsoft.TestPlatform.Build.sourcebuild.product.nuspec + Microsoft.TestPlatform.Build.sourcebuild.product.nuspec $(OutputPath) Microsoft.TestPlatform.Build vstest visual-studio unittest testplatform mstest microsoft test testing From d380ae7c07df894883a3633d36c31636a7e53bf8 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 6 Mar 2024 16:41:39 +0100 Subject: [PATCH 6/7] Update src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj Co-authored-by: Matt Mitchell --- .../Microsoft.TestPlatform.CLI.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj b/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj index 58512d2fc5..fbe092fa61 100644 --- a/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj +++ b/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj @@ -5,7 +5,7 @@ Microsoft.TestPlatform.CLI.nuspec - Microsoft.TestPlatform.CLI.sourcebuild.nuspec + Microsoft.TestPlatform.CLI.sourcebuild.nuspec Microsoft.TestPlatform.CLI.sourcebuild.product.nuspec true From ae2e78de02f23a33eb0df13ac8f09b1070ad336b Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 6 Mar 2024 16:41:44 +0100 Subject: [PATCH 7/7] Update src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj Co-authored-by: Matt Mitchell --- .../Microsoft.TestPlatform.CLI.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj b/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj index fbe092fa61..191f74e648 100644 --- a/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj +++ b/src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj @@ -6,7 +6,7 @@ Microsoft.TestPlatform.CLI.nuspec Microsoft.TestPlatform.CLI.sourcebuild.nuspec - Microsoft.TestPlatform.CLI.sourcebuild.product.nuspec + Microsoft.TestPlatform.CLI.sourcebuild.product.nuspec true false