Remove workaround for "unused" private fields #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisDenton I'm not sure when/what happened but it appears to no longer need the workaround. 😊 |
|
Do we need to leave this in for prior versions down to MSRV? I can't recall if this only showed up in unstable channels for a brief amount of time. |
|
As far as I know this was nightly only. Either way, we test stable/nightly/msrv - I don't think we can afford to test everything in between. 😊 |
|
It reached beta but the changes were reverted. So yeah should be fine to remove it now. I was waiting a bit to make sure the dust had settled before following up. But I forgot. 😔 |
riverar
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like newer nightly builds have fixed this problem and the workaround #3103 is no longer needed.
rust-lang/rust#126169 has also been closed.