-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YamlCreate] Read PFN from MSIX/APPX/Bundle without installing #129186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered this, but I didn't want to break any scripts or automations that were expecting the Y/N prompt. Unless you think it isn't a breaking change? I just figured better to be safe about it |
Ah, I see. I agree with the safer approach. |
This PR changes the logic for fetching PackageFamilyName so that instead of installing the package or bundle, it will convert the file to a Zip, extract the AppxManifest or AppxBundleManifest, and calculate the PFN. I decided to not remove the prompt asking if users wanted to detect automatically because I felt it could break some users if they were using YamlCreate in an automated way.
cc @russelbanks @mdanish-kh @OfficialEsco
Microsoft Reviewers: Open in CodeFlow