Fix issue when two filter "excludes" have the same string length #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue where supplying multiple excludes with the same length caused bad behavior in Release and asserts in Debug.
Added test cases, and the second test case, "filter_excludes_same_length" was hitting an assert in debug due to a malformed sorting predicate in the
filter
class. In the test case, bothcompare({"N.N3", false}, {"N.N4", false})
andcompare({"N.N4", false}, {"N.N3", false})
would returntrue
, violating sorting constraints.For the curious,
std::sort
(and the other C++ sortings I can think of) require a Strict Weak Ordering. What this means in C++ terms is, given a comparison objectcompare
, the following requirements must be met:compare(a, a) == false
for alla
compare(a, b) == true
thencompare(b, a) == false
compare(a, b) == true
andcompare(b, c) == true
thencompare(a, c) == true
compare(a, b) == false
andcompare(b, a) == false
andcompare(b, c) == false
andcompare(c, b) == false
thencompare(a, c) == false
andcompare(c, a) == false
(aka transitivity of equivalence)Fixes #21