This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Forms: Bump to latest stable (2.5.0). #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojanrajkovic
requested review from
abock,
lewing and
sandyarmstrong
as code owners
added 2 commits
December 6, 2017 15:32
There was some sort of dependency snafu with Xamarin.Forms and the Android support packages. The easiest approach is to compile against 7.0/7.1, but retain our older target SDK version.
When inspecting a Forms app, we load the Xamarin.Forms agent extensions while we're creating the compilation workspace. We need to pass the current session's evaluation context ID, but we can't access it via `clientSession.CompilationWorkspace`, as that's what we're building now (the compilation workspace), and the property is null. It's available to both callers of this method, so pass it in as a parameter instead of trying to get it via the client session.
abock
approved these changes
Dec 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump our enforced Xamarin.Forms version to the latest stable version, and fix inspection of Xamarin.Forms apps.
Read each commit individually for maximum clarity.