From 74af1c99a294c1a672acf34bb372f593d069b9b5 Mon Sep 17 00:00:00 2001
From: Jamie Snape <jamie.snape@kitware.com>
Date: Tue, 20 Jan 2015 12:53:41 -0500
Subject: [PATCH] Add missing HTML form labels in tracker module

---
 modules/tracker/views/producer/edit.phtml | 12 ++++++------
 modules/tracker/views/trend/edit.phtml    |  6 +++---
 modules/tracker/views/trend/notify.phtml  |  6 +++---
 modules/tracker/views/trend/view.phtml    | 16 ++++++++--------
 4 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/modules/tracker/views/producer/edit.phtml b/modules/tracker/views/producer/edit.phtml
index fd66a46a4..beeae1184 100644
--- a/modules/tracker/views/producer/edit.phtml
+++ b/modules/tracker/views/producer/edit.phtml
@@ -30,25 +30,25 @@
           method="POST">
         <div class="formRow">
             <label for="displayName">Name</label>
-            <input type="text" name="displayName" value="<?php echo $this->producer->getDisplayName(); ?>"/>
+            <input type="text" id="displayName" name="displayName" value="<?php echo $this->producer->getDisplayName(); ?>"/>
         </div>
         <div class="formRow">
             <label for="description">Description</label>
-            <textarea class="description" name="description"><?php echo $this->producer->getDescription(); ?></textarea>
+            <textarea class="description" id="description" name="description"><?php echo $this->producer->getDescription(); ?></textarea>
         </div>
         <div class="formRow">
             <label for="repository">Repository URL</label>
-            <input type="text" name="repository" value="<?php echo $this->producer->getRepository(); ?>"/>
+            <input type="text" id="repository" name="repository" value="<?php echo $this->producer->getRepository(); ?>"/>
         </div>
         <div class="formRow">
             <label for="revisionUrl">Revision URL</label>
-            <input type="text" name="revisionUrl" value="<?php echo $this->producer->getRevisionUrl(); ?>"/>
+            <input type="text" id="revisionUrl" name="revisionUrl" value="<?php echo $this->producer->getRevisionUrl(); ?>"/>
         </div>
         <div class="formRow">
             <label for="executableName">Executable Name</label>
-            <input type="text" name="executableName" value="<?php echo $this->producer->getExecutableName(); ?>"/>
+            <input type="text" id="executableName" name="executableName" value="<?php echo $this->producer->getExecutableName(); ?>"/>
         </div>
-        <input type="hidden" name="producerId" value="<?php echo $this->producer->getKey(); ?>"/>
+        <input type="hidden" id="producerId" name="producerId" value="<?php echo $this->producer->getKey(); ?>"/>
 
         <div class="submitButtonContainer">
             <input type="submit" class="globalButton" value="Save"/>
diff --git a/modules/tracker/views/trend/edit.phtml b/modules/tracker/views/trend/edit.phtml
index 257185e5c..47841329d 100644
--- a/modules/tracker/views/trend/edit.phtml
+++ b/modules/tracker/views/trend/edit.phtml
@@ -32,17 +32,17 @@ $this->headScript()->appendFile($this->coreWebroot.'/public/js/jquery/jquery.for
           method="POST">
         <div class="formRow">
             <label for="metricName">Metric name</label>
-            <input type="text" name="metricName" value="<?php echo $this->escape($this->trend->getMetricName()); ?>"
+            <input type="text" id="metricName" name="metricName" value="<?php echo $this->escape($this->trend->getMetricName()); ?>"
                    qtip="The metric name that submission clients use to identify this trend"/>
         </div>
         <div class="formRow">
             <label for="displayName">Display name</label>
-            <input type="text" name="displayName" value="<?php echo $this->escape($this->trend->getDisplayName()); ?>"
+            <input type="text" id="displayName" name="displayName" value="<?php echo $this->escape($this->trend->getDisplayName()); ?>"
                    qtip="The title that is displayed in Midas for this trend"/>
         </div>
         <div class="formRow">
             <label for="unit">Unit</label>
-            <input type="text" name="unit" value="<?php echo $this->escape($this->trend->getUnit()); ?>"
+            <input type="text" id="unit" name="unit" value="<?php echo $this->escape($this->trend->getUnit()); ?>"
                    qtip="The unit of measurement for this metric (optional)"/>
         </div>
         <div class="formRow">
diff --git a/modules/tracker/views/trend/notify.phtml b/modules/tracker/views/trend/notify.phtml
index 74e4b5d2a..2c012c478 100644
--- a/modules/tracker/views/trend/notify.phtml
+++ b/modules/tracker/views/trend/notify.phtml
@@ -26,10 +26,10 @@
 <form id="thresholdNotifyForm" class="genericForm" method="POST"
       action="<?php echo $this->webroot ?>/tracker/trend/notifysubmit">
     <div>
-        <input type="radio" id="noNotify" name="doNotify" value="no"/>Do not send me emails for this trend
+        <input type="radio" id="noNotify" name="doNotify" value="no"/><label for="noNotify">Do not send me emails for this trend</label>
     </div>
     <div>
-        <input type="radio" id="yesNotify" name="doNotify" value="yes"/>Send me an email alert
+        <input type="radio" id="yesNotify" name="doNotify" value="yes"/><label for="yesNotify">Send me an email alert</label>
     </div>
     <div class="thresholdInfoContainer">
         When submitted value is
@@ -39,7 +39,7 @@
             <option value="&gt;=">&gt;=</option>
             <option value="&lt;=">&lt;=</option>
         </select>
-        <input type="text" class="thresholdValue" name="value"
+        <input type="text" class="thresholdValue" id="value" name="value"
             <?php
             if ($this->setting) {
                 echo ' value="'.$this->escape($this->setting->getValue()).'"';
diff --git a/modules/tracker/views/trend/view.phtml b/modules/tracker/views/trend/view.phtml
index d52d7c868..d084a9d12 100644
--- a/modules/tracker/views/trend/view.phtml
+++ b/modules/tracker/views/trend/view.phtml
@@ -174,19 +174,19 @@ $this->headScript()->appendFile($this->coreWebroot.'/public/js/jquery/jqplot/jqp
     <table class="yValuesTable">
         <tbody>
         <tr>
-            <th>Y range:</th>
-            <td><input class="yMin" type="text"/></td>
-            <td>to</td>
-            <td><input class="yMax" type="text"/></td>
+            <th><label for="yMin">Y range:</label></th>
+            <td><input id="yMin" class="yMin" type="text"/></td>
+            <td><label for="yMax">to</label></td>
+            <td><input id="yMax" class="yMax" type="text"/></td>
         </tr>
         <?php
         if ($this->rightTrend) {
             ?>
             <tr>
-                <th>Y2 range:</th>
-                <td><input class="y2Min" type="text"/></td>
-                <td>to</td>
-                <td><input class="y2Max" type="text"/></td>
+                <th><label for="y2Min">Y2 range:</label></th>
+                <td><input id="y2Min" class="y2Min" type="text"/></td>
+                <td><label for="y2Max">to</label></td>
+                <td><input id="y2Max"  type="text"/></td>
             </tr>
         <?php
         }