Do not use libtool for dynamic library management #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Cormack <justin.cormack@docker.com>
|
lgtm and travis is happy |
|
For what it's worth, ltdl is licensed under LGPL which should be compatible. But eliminating the dependency here seems like a good idea for many practical reasons. http://git.savannah.gnu.org/cgit/libtool.git/tree/libltdl/ltdl.c |
jls5177
added a commit
to jls5177/pkcs11
that referenced
this pull request
Jun 19, 2019
This reverts commit 6120d95 as I am seeing issues on Windows platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libtool is licensed GPL unless your software is built with libtool, which rather conflicts with the fact that this library is otherwise BSD licensed.
Using
dlopenon Unix andLoadLibraryon Windows is pretty simple as we are not doing anything complicated.Tested on Linux, OSX and Windows.