EDDSA Support #145
Closed
EDDSA Support #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Wallis <ivan.wallis@venafi.com>
Signed-off-by: Ivan Wallis <ivan.wallis@venafi.com>
Signed-off-by: Ivan Wallis <ivan.wallis@venafi.com>
Closed
miekg
reviewed
Dec 28, 2021
| @@ -536,6 +536,7 @@ const ( | |||
| CKM_ECMQV_DERIVE = 0x00001052 | |||
| CKM_ECDH_AES_KEY_WRAP = 0x00001053 | |||
| CKM_RSA_AES_KEY_WRAP = 0x00001054 | |||
| CKM_EDDSA = 0x00001057 | |||
There was a problem hiding this comment.
is there a link for me to verify this number?
There was a problem hiding this comment.
There was a problem hiding this comment.
why do we need to add this manually instead of updating pkcs11.h and regenning the go code?
There was a problem hiding this comment.
I'm open to either way, but if we go down the regen approach then there needs to be documented steps on how to do so, such as in a Makefile.
miekg
reviewed
Dec 28, 2021
Signed-off-by: Ivan Wallis <ivan.wallis@venafi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support EDDSA signing/verification functionality.