Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaflet icon/draggability bug, dragging object can be undefined for hidden markers (related to #77) #513

Closed
ludo-syt opened this issue Jul 24, 2020 · 2 comments

Comments

@ludo-syt
Copy link

Hello there, I have an issue with the marker-layer "iconDidChange" observer, the "dragging" object is sometimes undefined.
Note that we use Ember Leaflet Marker Cluster and the bug appears in cluster mode. Hidden markers don't have the "dragging" property as they are not rendered, however iconDidChange is triggered for those markers.
Our markers are not draggable.

Maybe you can check that this._layer.dragging object is valid before calling enable/disable.
Leaflet doc says on "dragging" property : "Only valid when the marker is on the map" Doc

Thank you for your help

image
image

@miguelcobain
Copy link
Owner

@ludo-syt released a fix on version 4.1.1.

@ludo-syt
Copy link
Author

ludo-syt commented Aug 3, 2020

Thank you @miguelcobain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants