leaflet-map: pass more options #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addon/components/leaflet-map.js
Outdated
| @@ -39,7 +40,9 @@ export default BaseLayer.extend(ParentMixin, { | |||
| ], | |||
|
|
|||
| leafletProperties: [ | |||
| 'zoom:setZoom:zoomPanOptions', 'center:panTo:zoomPanOptions', 'maxBounds:setMaxBounds', 'bounds:fitBounds:fitBoundsOptions' | |||
| 'zoom:setZoom:zoomPanOptions', 'minZoom:setMinZoom:zoomPanOptions', 'maxZoom:setMaxZoom:zoomPanOptions', | |||
There was a problem hiding this comment.
Do we need the :zoomPanOptions part here for minZoom and maxZoom?
AFAIK, setMinZoom and setMaxZoom accept only one argument which is the zoom level itself.
There was a problem hiding this comment.
You're absolutely right.
buschtoens
force-pushed
the
pass-more-options-to-map
branch
2 times, most recently
from
9e76065
to
f19a92d
Compare
addon/components/leaflet-map.js
Outdated
| 'zoom:setZoom:zoomPanOptions', 'center:panTo:zoomPanOptions', 'maxBounds:setMaxBounds', 'bounds:fitBounds:fitBoundsOptions' | ||
| 'zoom:setZoom:zoomPanOptions', 'minZoom', 'maxZoom', | ||
| 'center:panTo:zoomPanOptions', | ||
| 'bounds:fitBounds:fitBoundsOptions', 'maxBounds', |
|
Can you add an entry to the changelog please? This looks good to me! Thank you. You can add an entry for "master" in the changelog. |
buschtoens
force-pushed
the
pass-more-options-to-map
branch
from
f19a92d
to
57b596c
Compare
|
Removed the dangling comma and added a changelog entry. 😊 |
|
Thank you so much! |
miguelcobain
pushed a commit
that referenced
this pull request
Feb 4, 2019
Bumps [eslint-plugin-node](https://github.com/mysticatea/eslint-plugin-node) from 6.0.1 to 8.0.1. <details> <summary>Release notes</summary> *Sourced from [eslint-plugin-node's releases](https://github.com/mysticatea/eslint-plugin-node/releases).* > ## v8.0.1 > ## 🐛 Bug fixes > > - 62ba6425a73845c235e93d706b7d826f70853c40 fixed the wrong messages of `node/no-deprecated-api` rule ([#142](https://github-redirect.dependabot.com/mysticatea/eslint-plugin-node/issues/142)). > - 0225b02d0f3f8dbf2d2d52577455bf9817e925ca...0593c67576c86b2cbf4990db38d1cc4707b2f309 fixed the false positives of `no-unpublished-(bin|import|require)` rules ([#115](https://github-redirect.dependabot.com/mysticatea/eslint-plugin-node/issues/115), [#126](https://github-redirect.dependabot.com/mysticatea/eslint-plugin-node/issues/126)). > > ## v8.0.0 > This release focuses on supporting new things that were added between Node.js 8.7.0 and 11.0.0. > > ## Breaking changes > > - 58607951356dc63cd33366282eeda98ebd587dd0 updated `node/no-deprecated-api` rule to disallow new deprecated APIs. > Especially, it includes [legacy URL API](https://nodejs.org/dist/v11.0.0/docs/api/url.html#url_legacy_url_api). > - d153b93809c079b1be64aab706c14efb0da7991f updated `node/no-unsupported-features/node-builtins` rule to detect new APIs. > > ## New rules > > - 46ed54dc3931bbf78c6b6d0761201867c74c033f added `node/prefer-global/text-decoder` rule for new global varaible `TextDecoder`. > - 46ed54dc3931bbf78c6b6d0761201867c74c033f added `node/prefer-global/text-encoder` rule for new global varaible `TextEncoder`. > > ## v7.0.1 > ## Bug fixes > > - It fixed false positive that the `node/no-unsupported-features/node-builtins` reports the `process.emitWarning` method on Node.js `>=6 <8`. It was supported since Node.js 6.0.0. > > ## v7.0.0 > ## Breaking changes > > - It dropped the support of Node.js 4. Now it requires `>=6`. > - It dropped the support of ESLint 3. Now it requires `>=4.19.1`. (the `node/recommended` preset is supporting only ESLint `>=5.0.0`) > - It updated the `node/recommended` config. > - changed `parserOptions.ecmaVersion` to `2019` from `2018`. > - added `plugins: ["node"]`. > - removed a deprecated rule: [node/no-unsupported-features]. > - added three new rules: > - [node/no-unsupported-features/es-builtins] > - [node/no-unsupported-features/es-syntax] > - [node/no-unsupported-features/node-builtins]. > - It updated the [node/no-deprecated-api] rule to support Node.js up to `10.6.0`. > - Note some assertion methods such as `assert.equal` are deprecated. Use stricter methods such as `assert.strictEqual` or the strict mode (`assert.strict`) instead. > > ## New rules > > - [node/no-unsupported-features/es-builtins] ... disallow unsupported ECMAScript built-in globals on the configured Node.js version. > - [node/no-unsupported-features/es-syntax] ... disallow unsupported ECMAScript syntax on the configured Node.js version. > - [node/no-unsupported-features/node-builtins] ... disallow unsupported Node.js built-in modules and globals on the configured Node.js version. > - [node/prefer-global/buffer] ... enforce the use of either `Buffer` or `require("buffer").Buffer` consistently. > - [node/prefer-global/console] ... enforce the use of either `console` or `require("console")` consistently. > - [node/prefer-global/process] ... enforce the use of either `process` or `require("process")` consistently. > - [node/prefer-global/url-search-params] ... enforce the use of either `URLSearchParams` or `require("url").URLSearchParams` consistently. ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`b234dcc`](mysticatea/eslint-plugin-node@b234dcc) 8.0.1 - [`0593c67`](mysticatea/eslint-plugin-node@0593c67) 🎨 remove garbage - [`679752b`](mysticatea/eslint-plugin-node@679752b) 🐛 fix no-unpublished-(require|import) false positive (fixes [#126](https://github-redirect.dependabot.com/mysticatea/eslint-plugin-node/issues/126)) - [`e2fc482`](mysticatea/eslint-plugin-node@e2fc482) 🐛 fix no-unpublished-bin false positive (fixes [#115](https://github-redirect.dependabot.com/mysticatea/eslint-plugin-node/issues/115)) - [`0225b02`](mysticatea/eslint-plugin-node@0225b02) 🎨 rename a function - [`43e3198`](mysticatea/eslint-plugin-node@43e3198) ⚒ disable codecov comments - [`62ba642`](mysticatea/eslint-plugin-node@62ba642) 🐛 fix no-deprecated-api error messages ([#147](https://github-redirect.dependabot.com/mysticatea/eslint-plugin-node/issues/147)) - [`153ab03`](mysticatea/eslint-plugin-node@153ab03) Chore: support the new rule `meta.type` property (fixes [#143](https://github-redirect.dependabot.com/mysticatea/eslint-plugin-node/issues/143)) ([#145](https://github-redirect.dependabot.com/mysticatea/eslint-plugin-node/issues/145)) - [`932836b`](mysticatea/eslint-plugin-node@932836b) 8.0.0 - [`c849a27`](mysticatea/eslint-plugin-node@c849a27) Chore: update .travis.yml - Additional commits viewable in [compare view](mysticatea/eslint-plugin-node@v6.0.1...v8.0.1) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=eslint-plugin-node&package-manager=npm_and_yarn&previous-version=6.0.1&new-version=8.0.1) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing options to
{{leaflet-map}}:easeLinearityworldCopyJumpmaxBoundsViscosityIt also enables observers for
minZoomandmaxZoom.