From 7d1fab4bbd1dce723bbfcd6120923f1907609087 Mon Sep 17 00:00:00 2001 From: Roshan Varughese <40583749+Animeboynz@users.noreply.github.com> Date: Tue, 2 Jul 2024 23:01:25 +1200 Subject: [PATCH 1/4] Smart Update Dialog Fix --- .../kanade/presentation/manga/components/MangaDialogs.kt | 8 ++++++++ i18n/src/commonMain/moko-resources/base/strings.xml | 1 + 2 files changed, 9 insertions(+) diff --git a/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt b/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt index a6ef3f9a56..10793babdb 100644 --- a/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt +++ b/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt @@ -105,6 +105,14 @@ fun SetIntervalDialog( Spacer(Modifier.height(MaterialTheme.padding.small)) } + else + { + Text( + stringResource(MR.strings.manga_interval_expected_update_null), + ) + + Spacer(Modifier.height(MaterialTheme.padding.small)) + } if (onValueChanged != null && (isDevFlavor || isPreviewBuildType)) { Text(stringResource(MR.strings.manga_interval_custom_amount)) diff --git a/i18n/src/commonMain/moko-resources/base/strings.xml b/i18n/src/commonMain/moko-resources/base/strings.xml index a3e7c3afdd..08bbe2d763 100644 --- a/i18n/src/commonMain/moko-resources/base/strings.xml +++ b/i18n/src/commonMain/moko-resources/base/strings.xml @@ -693,6 +693,7 @@ Set to update every New chapters predicted to be released in around %1$s, checking around every %2$s. + This manga is either completed, or there is no predicted release date. Soon Custom update frequency: Downloading (%1$d/%2$d) From db517d7c96a61a160ef284aa2ae31f9ee7d311e9 Mon Sep 17 00:00:00 2001 From: Roshan Varughese <40583749+Animeboynz@users.noreply.github.com> Date: Tue, 2 Jul 2024 23:18:27 +1200 Subject: [PATCH 2/4] Build Fail Change 1 --- .../eu/kanade/presentation/manga/components/MangaDialogs.kt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt b/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt index 10793babdb..ffcca9b768 100644 --- a/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt +++ b/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt @@ -104,9 +104,7 @@ fun SetIntervalDialog( ) Spacer(Modifier.height(MaterialTheme.padding.small)) - } - else - { + } else { Text( stringResource(MR.strings.manga_interval_expected_update_null), ) From 9eb92093d2e5c4b3c44fcbf371e61fb38bacfe3a Mon Sep 17 00:00:00 2001 From: Roshan Varughese <40583749+Animeboynz@users.noreply.github.com> Date: Tue, 2 Jul 2024 23:53:00 +1200 Subject: [PATCH 3/4] Commit Suggested Change Co-authored-by: AntsyLich <59261191+AntsyLich@users.noreply.github.com> --- .../eu/kanade/presentation/manga/components/MangaDialogs.kt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt b/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt index ffcca9b768..3eeb9b6fb5 100644 --- a/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt +++ b/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt @@ -103,14 +103,12 @@ fun SetIntervalDialog( ), ) - Spacer(Modifier.height(MaterialTheme.padding.small)) } else { Text( stringResource(MR.strings.manga_interval_expected_update_null), ) - - Spacer(Modifier.height(MaterialTheme.padding.small)) } + Spacer(Modifier.height(MaterialTheme.padding.small)) if (onValueChanged != null && (isDevFlavor || isPreviewBuildType)) { Text(stringResource(MR.strings.manga_interval_custom_amount)) From 4a45938d7092fe578e0ee3779003e5ba6f98e0ed Mon Sep 17 00:00:00 2001 From: Roshan Varughese <40583749+Animeboynz@users.noreply.github.com> Date: Tue, 2 Jul 2024 23:58:35 +1200 Subject: [PATCH 4/4] Build Fail Change 2 --- .../java/eu/kanade/presentation/manga/components/MangaDialogs.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt b/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt index 3eeb9b6fb5..bee8a8844d 100644 --- a/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt +++ b/app/src/main/java/eu/kanade/presentation/manga/components/MangaDialogs.kt @@ -102,7 +102,6 @@ fun SetIntervalDialog( ), ), ) - } else { Text( stringResource(MR.strings.manga_interval_expected_update_null),