Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False boolean does not override true boolean when merging (2.4.1) #512

Closed
FranckKe opened this issue Aug 10, 2020 · 2 comments
Closed

False boolean does not override true boolean when merging (2.4.1) #512

FranckKe opened this issue Aug 10, 2020 · 2 comments

Comments

@FranckKe
Copy link

Thank you for developing yq :)

Description
Merging a false boolean into a true boolean does not work as expected.

version of yq: 2.4.1
operating system: Docker (mikefarah/yq:2)

Input Yaml
data1.yml:

key:
  value: false

data2.yml:

key:
  value: true

Command
The command you ran:

yq merge data1.yml data2.yml

Actual behavior

key1:
  value: true

Expected behavior

key:
  value: false

Additional context
It works fine with yq 3+. I'm using 2 until #455 is addressed.
My workaround is to cast boolean as a string and remove quotes after the merging is done.

@FranckKe FranckKe added the bug label Aug 10, 2020
@mikefarah
Copy link
Owner

#455 has been fixed in 3.4.0

@mikefarah
Copy link
Owner

Marking as 'wontfix' as I'm no longer supporting v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants