Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[travis] - add actionmailer #1303

Merged
merged 1 commit into from
Dec 19, 2018
Merged

[travis] - add actionmailer #1303

merged 1 commit into from
Dec 19, 2018

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Dec 19, 2018

add action mailer job #1300

@ahorek
Copy link
Contributor Author

ahorek commented Dec 19, 2018

@jeremy do you have an idea how to fix? could you try to upgrade rvm and gpg keys manually?

https://travis-ci.org/mikel/mail/jobs/470182472

rvm get master
Downloading https://get.rvm.io
Downloading https://raw.githubusercontent.com/rvm/rvm/master/binscripts/rvm-installer.asc
Verifying /home/travis/.rvm/archives/rvm-installer.asc
gpg: Signature made Wed 12 Dec 2018 04:06:03 PM UTC using RSA key ID 39499BDB
gpg: Can't check signature: No public key
Warning, RVM 1.26.0 introduces signed releases and automated check of signatures when GPG software found. Assuming you trust Michal Papis import the mpapis public key (downloading the signatures).
GPG signature verification failed for '/home/travis/.rvm/archives/rvm-installer' - 'https://raw.githubusercontent.com/rvm/rvm/master/binscripts/rvm-installer.asc'! Try to install GPG v2 and then fetch the public key:
    gpg2 --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3
or if it fails:
    command curl -sSL https://rvm.io/mpapis.asc | gpg2 --import -
the key can be compared with:
    https://rvm.io/mpapis.asc
    https://keybase.io/mpapis
NOTE: GPG version 2.1.17 have a bug which cause failures during fetching keys from remote server. Please downgrade or upgrade to newer version (if available) or use the second method described above.
/home/travis/.rvm/scripts/functions/cli: line 243: return: _ret: numeric argument required

@ahorek ahorek changed the title WIP: travis [travis] - update rubies and add actionmailer Dec 19, 2018
.travis.yml Outdated
@@ -21,8 +21,7 @@ rvm:
- ruby-head
- jruby
- jruby-head
- rbx-2
- rbx-3
- truffleruby
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave rbx as-is and add truffleruby in a separate PR. This PR can focus on integration testing with Action Mailer alone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

.travis.yml Show resolved Hide resolved
echo "" >> Gemfile
echo "gem 'mail', path: '../'" >> Gemfile
rm -rf Gemfile.lock
bundle install
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle update --source mail may be sufficient, rather than removing the lock and reinstalling

rm -rf Gemfile.lock
bundle install
cd actionmailer
bundle install
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second bundle install is superfluous. Can remove it.

@ahorek ahorek changed the title [travis] - update rubies and add actionmailer [travis] - add actionmailer Dec 19, 2018
Copy link
Collaborator

@jeremy jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jeremy jeremy merged commit eb0edc1 into mikel:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants