-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[travis] - add actionmailer #1303
Conversation
@jeremy do you have an idea how to fix? could you try to upgrade rvm and gpg keys manually? https://travis-ci.org/mikel/mail/jobs/470182472
|
.travis.yml
Outdated
@@ -21,8 +21,7 @@ rvm: | |||
- ruby-head | |||
- jruby | |||
- jruby-head | |||
- rbx-2 | |||
- rbx-3 | |||
- truffleruby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave rbx as-is and add truffleruby in a separate PR. This PR can focus on integration testing with Action Mailer alone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
spec/travis-actionmailer.sh
Outdated
echo "" >> Gemfile | ||
echo "gem 'mail', path: '../'" >> Gemfile | ||
rm -rf Gemfile.lock | ||
bundle install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bundle update --source mail
may be sufficient, rather than removing the lock and reinstalling
spec/travis-actionmailer.sh
Outdated
rm -rf Gemfile.lock | ||
bundle install | ||
cd actionmailer | ||
bundle install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second bundle install is superfluous. Can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
add action mailer job #1300