Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to override db connection and other settings for gitlab CI #11

Open
sharique opened this issue Jun 4, 2021 · 2 comments
Open

Comments

@sharique
Copy link

sharique commented Jun 4, 2021

Currently the settings file path is hardcoded to load from vendor folder (vendor/mikemadison13/blt-gitlab-pipelines/settings/gitlab.settings.php). It should be able to load from settings folder.

@mikemadison13
Copy link
Owner

This move was intentional to be inline with how BLT handles this for Acquia Pipelines (see https://github.com/acquia/blt/blob/main/settings/pipelines.settings.php). This isn't something that gets moved into the settings folder, it's something that is just in the plugin.

Is there a reason why it should be in settings?

@sharique sharique changed the title Take settings file from files folder Ability to override db settings Oct 4, 2021
@sharique
Copy link
Author

sharique commented Oct 4, 2021

What I need to the ability override the db connection settings (settings folder is idea place), if somebody using different db.

Recently I was doing a small POC, where I was using Postgres DB in local, but I've use MySql in gitlab CI, as I didn't fine a way override db settings.

It will be good if we can have documentation on how to override db and other settings, may be I should create a separate ticket for it.

@sharique sharique changed the title Ability to override db settings Ability to override db connection and settings for gitlab CI Oct 4, 2021
@sharique sharique changed the title Ability to override db connection and settings for gitlab CI Ability to override db connection and other settings for gitlab CI Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants