Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to jsonwebtoken v8.1.0 #133

Closed
wants to merge 1 commit into from

Conversation

gswalden
Copy link

The jsonwebtoken migration guide does not note any breaking changes related to this library's usage. All tests pass.

Closes #131

@gswalden
Copy link
Author

maxAge verification option expects seconds or a string describing a time span (i.e: '2 days'). It accepted milliseconds in v7, which did not make sense since JWTs times are expressed in seconds.

I suppose this could affect passport-jwt users, so not sure if this should be a major version or patch.

@XVincentX
Copy link

Is this landing anytime soon?

@BorntraegerMarc
Copy link

Still no Update?

@JulianLaval
Copy link

Any updates on this? The package currently relies on a now-vulnerable version of jsonwebtoken (see #147), so acceptance of this PR would be greatly appreciated! 🙂

@XVincentX
Copy link

I am afraid the original author is not going to look at this any time soon.

@JulianLaval JulianLaval mentioned this pull request Feb 21, 2018
@JulianLaval
Copy link

@XVincentX we've gone ahead and forked this repo & updated the dependency -- feel free to use it: https://github.com/CenterHealth/passport-jwt

@kujon
Copy link

kujon commented Feb 27, 2018

@JulianLaval do you mind publishing it to npm please?

@JulianLaval
Copy link

@kujon Happy to, although I'm guessing I'd probably revert back to the original if it ever gets updated. Would it maybe be preferable to reference the fork from your package.json?

// In your dependencies
"passport-jwt": "centerhealth/passport-jwt"

NPM explicitly supports GitHub URLs, see here.

If you'd still like me to publish on NPM, let me know!

@thiagobustamante
Copy link

@themikenicholson Any news?

@mikenicholson
Copy link
Owner

mikenicholson commented Mar 13, 2018

Updated to 8.2.0.

Didn't merge this PR since I went with the latest version of jsonwebtoken. Thanks for bringing it to my attention.

I'm very sorry for taking so long to get to this. Life got busy for a few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants