Fix "spawn sirv ENOENT" error caused by Windows OS #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the messy commit history! Think I sorted it all out though, so it should all be one smooth commit. I realized other bugs I had encountered were also due to how Windows deals with spawning child processes, and the best solution was to add the cross-spawn package. |
|
Bump @milahu 😊 not sure if you get notified on PRs or not |
|
thanks!
no, but should ... edit: sorry im too stupid to merge ^^ this should be in master branch edit: all good, i just noticed this is a PR for my PR fpapado#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an annoying quirk of Windows as documented in nodejs/node#3675, which causes an
ENOENTerror when trying to spawn a new child process forsirv