Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build and pack as .NET tool #2

Open
wants to merge 1 commit into
base: net60
Choose a base branch
from
Open

Fix build and pack as .NET tool #2

wants to merge 1 commit into from

Conversation

josesimoes
Copy link

@josesimoes josesimoes commented Feb 24, 2023 •
edited
Loading

  • Adjust target frameworks.
  • Migrate current projects to 4.7.2, add also to target framework in projects referencing these.
  • Rework referencing projects to get proper referencing.
  • Fix output type of TFConvert to output executable.
  • Add hack to allow package as .NET tool despite being able to run only on windows.
  • Add check for running on Windows platform.
  • Move properties to package as tool to main project.
  • Assembly name, package id and tool command name are now all lower case and the same for consistency.

@josesimoes
Fix build and pack as .NET tool
1860cd3 
- Adjust target frameworks.
- Migrate current projects to 4.7.2, add also to target framework in projects referencing these.
- Rework referencing projects to get proper referencing.
- Fix output type of TFConvert to output executable.
- Add hack to allow package as .NET tool despite being able to run only on windows.
- Add check for running on Windows platform.
- Move properties to package as tool to main project.
- Assembly name, package id and tool command name are now all lower case and the same for consistency.
@josesimoes josesimoes mentioned this pull request Feb 24, 2023
Open
@miloush
Copy link
Owner

miloush commented Feb 26, 2023

This gives me

The settings file in the tool's NuGet package is invalid: Entry point file 'tfconvert.dll' for command 'tfconvert' was not found in the package.
Tool 'tfconvert' failed to install. Contact the tool author for assistance.

Can you comment on commenting out some of the tests?

@josesimoes
Copy link
Author

Yes, I can see the same here when trying to install... will try some workarounds in the coming days
As for the testing I comment out those who weren't possible to run because of the change to the new target framework. Most likely they just need some tweak or minor rework. Didn't spent much time on it.

@josesimoes
Copy link
Author

This is defenitly not working at all!

I'm thinking that another approach could be to have the CLI build as a .NET tool, but instead of TFConvert being the tool it would be instead a wrapper that would call the "original" TFConvert CLI that can be build as usual (just that updated to the latest .NET Framework version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @miloush