Circuit is not properly updated when changed by pistons

[bodqhrohro]

I see some similar recent issues related to overheat, so maybe it's the cause this time too?

[Desour]

I'm able to reproduce.
The pos where the node came from is updated correctly, the destination however isn't.
(See

mesecons/mesecons_mvps/init.lua

Line 241 in 68c1729

for source.)

[bodqhrohro]

So how to fix it? I tried to replace it with updating both positions:

diff --git a/mesecons_mvps/init.lua b/mesecons_mvps/init.lua
index 807692e..dd4e56f 100644
--- a/mesecons_mvps/init.lua
+++ b/mesecons_mvps/init.lua
@@ -239,11 +239,6 @@ function mesecon.mvps_push_or_pull(pos, stackdir, movedir, maximum, all_pull_sti
                minetest.remove_node(n.pos)
        end
 
-       -- update mesecons for removed nodes ( has to be done after all nodes have been removed )
-       for _, n in ipairs(nodes) do
-               mesecon.on_dignode(n.pos, n.node)
-       end
-
        -- add nodes
        for _, n in ipairs(nodes) do
                local np = vector.add(n.pos, movedir)
@@ -267,6 +262,12 @@ function mesecon.mvps_push_or_pull(pos, stackdir, movedir, maximum, all_pull_sti
                moved_nodes[i].node_timer = nodes[i].node_timer
        end
 
+       -- update the moved mesecons
+       for _, n in ipairs(moved_nodes) do
+               mesecon.on_dignode(n.oldpos, n.node)
+               mesecon.on_dignode(n.pos, n.node)
+       end
+
        on_mvps_move(moved_nodes)
 
        return true, nodes, oldstack

But it didn't help.

[numberZero]

Dupe of #406