fix: remove unnecessary check and update documentation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor code to stop creating empty action. move deploy code sections to separate methods. add some logging to be reported to the action log.
minherz
added a commit
that referenced
this pull request
May 24, 2024
refactor code to stop creating an empty action. refactor code to move deploy code to stand alone methods. change log severity to report errors. add extra info logs to improve verbosity of the action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the action by removing code that creates additional check.
Allow to pass the path to the service account key file instead of the JSON configuration of the service account key.
Add a paragraph to README to reference to the keyless authentication action.