Sets sslProtocol per dotnet version #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijn00
approved these changes
Aug 11, 2023
Contributor
|
@ebozduman @harshavardhana can you merge this? |
Collaborator
Author
|
@harshavardhana , |
ebozduman
requested review from
Praveenrajmani,
balamurugana and
krisis
and removed request for
harshavardhana
Collaborator
Author
|
@praveen, @balamurugana , @krisis |
balamurugana
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #799 (can be closed).
Subnet customer hit the error "Operation not supported", while trying to create a certificate identity provider using an old but still supported dotnet release version, .net462.
That is because
System.Net.Http.HttpClientHandlerdid not supportSslProtocolsproperty to set the protocol type for all supported dotnet release versions older than .net472.So the protocol type is needed to be set using
System.Net.ServicePointManager.SecurityProtocolproperty to support dotnet release versions older than .net472.