From c5af5e64351495eaefa4bf99f7e4dc3e9bc18515 Mon Sep 17 00:00:00 2001
From: Nitish Tiwari <nitish@minio.io>
Date: Fri, 3 Jul 2020 12:49:01 +0530
Subject: [PATCH] Remove Istio example

The Istio example doesn't work properly. It is better to route
users to Istio documentation so they can set it up properly.

We can revisit adding the example later if there is a working
example.
---
 README.md                      | 11 +----------
 examples/expose-via-istio.yaml | 30 ------------------------------
 2 files changed, 1 insertion(+), 40 deletions(-)
 delete mode 100644 examples/expose-via-istio.yaml

diff --git a/README.md b/README.md
index 4c965ac2869..043262dfb4a 100644
--- a/README.md
+++ b/README.md
@@ -51,16 +51,6 @@ kubectl apply -f https://raw.githubusercontent.com/minio/minio-operator/master/e
 
 Add an [external service](https://kubernetes.io/docs/concepts/services-networking/service/) in MinIOInstance definition to enable Service based access to the MinIOInstance pods. Refer [the example here](https://github.com/minio/minio-operator/blob/master/examples/minioinstance.yaml?raw=true) for details on how to setup service based access for MinIOInstance pods.
 
-### Advanced: Expose MinIO via Istio
-
-Istio >= 1.4 has support for headless Services, so instead of creating an explicit `Service` for the created MinIO instance, you can also directly target the headless Service that is created by the operator.
-
-For example, to expose the created headless Service `minio-hl-svc` on http://minio.example.com:
-
-```
-kubectl apply -f https://raw.githubusercontent.com/minio/minio-operator/master/examples/expose-via-istio.yaml
-```
-
 ### Environment variables
 
 These variables may be passed to operator Deployment in order to modify some of its parameters
@@ -76,3 +66,4 @@ These variables may be passed to operator Deployment in order to modify some of
 - [Use `mc` with MinIO Server](https://docs.min.io/docs/minio-client-quickstart-guide)
 - [Use `aws-cli` with MinIO Server](https://docs.min.io/docs/aws-cli-with-minio)
 - [The MinIO documentation website](https://docs.min.io)
+- Expose MinIO via Istio: Istio >= 1.4 has support for headless Services, so instead of creating an explicit `Service` for the created MinIO instance, you can also directly target the headless Service that is created by the operator. Use [Istio Ingress Gateway](https://istio.io/latest/docs/tasks/traffic-management/ingress/ingress-control/) to configure Istio to expose the MinIO service outside of the service mesh.
diff --git a/examples/expose-via-istio.yaml b/examples/expose-via-istio.yaml
deleted file mode 100644
index 624e02003a7..00000000000
--- a/examples/expose-via-istio.yaml
+++ /dev/null
@@ -1,30 +0,0 @@
-apiVersion: networking.istio.io/v1alpha3
-kind: Gateway
-metadata:
-  name: minio
-spec:
-  selector:
-    istio: ingressgateway
-  servers:
-    - port:
-        number: 80
-        name: http-minio
-        protocol: HTTP
-      hosts:
-        - "minio.example.com"
----
-apiVersion: networking.istio.io/v1alpha3
-kind: VirtualService
-metadata:
-  name: minio
-spec:
-  hosts:
-  - "minio.example.com"
-  gateways:
-  - minio
-  http:
-  - route:
-    - destination:
-        host: minio-hl-svc
-        port:
-          number: 9000