From d91092be194e517c89c8f32a30c2ee2fd4b22748 Mon Sep 17 00:00:00 2001 From: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> Date: Fri, 17 Nov 2023 12:22:51 -0800 Subject: [PATCH 1/2] Fix Controller comments Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com> --- pkg/controller/main-controller.go | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/pkg/controller/main-controller.go b/pkg/controller/main-controller.go index b88cc35d244..2e6f46e18d9 100644 --- a/pkg/controller/main-controller.go +++ b/pkg/controller/main-controller.go @@ -208,7 +208,7 @@ const ( LeaderElection ) -// EventNotification - structure to send messages trough a channel regarding a error event to be handled +// EventNotification - structure to send messages through a channel regarding a error event to be handled type EventNotification struct { // Err the error to handle if any, null when is just a message Err error @@ -216,8 +216,23 @@ type EventNotification struct { Type EventType } -// NewController returns a new sample controller -func NewController(podName string, namespacesToWatch set.StringSet, kubeClientSet kubernetes.Interface, k8sClient client.Client, minioClientSet clientset.Interface, promClient promclientset.Interface, statefulSetInformer appsinformers.StatefulSetInformer, deploymentInformer appsinformers.DeploymentInformer, podInformer coreinformers.PodInformer, tenantInformer informers.TenantInformer, policyBindingInformer stsInformers.PolicyBindingInformer, serviceInformer coreinformers.ServiceInformer, hostsTemplate, operatorVersion string) *Controller { +// NewController returns a new Operator Controller +func NewController( + podName string, + namespacesToWatch set.StringSet, + kubeClientSet kubernetes.Interface, + k8sClient client.Client, + minioClientSet clientset.Interface, + promClient promclientset.Interface, + statefulSetInformer appsinformers.StatefulSetInformer, + deploymentInformer appsinformers.DeploymentInformer, + podInformer coreinformers.PodInformer, + tenantInformer informers.TenantInformer, + policyBindingInformer stsInformers.PolicyBindingInformer, + serviceInformer coreinformers.ServiceInformer, + hostsTemplate, + operatorVersion string) *Controller { + // Create event broadcaster // Add minio-controller types to the default Kubernetes Scheme so Events can be // logged for minio-controller types. From 897e0dcb5a2681aea1be35333f6daf3ef6247ce2 Mon Sep 17 00:00:00 2001 From: pjuarezd Date: Mon, 20 Nov 2023 13:59:03 -0800 Subject: [PATCH 2/2] gofumpt Signed-off-by: pjuarezd --- pkg/controller/main-controller.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/controller/main-controller.go b/pkg/controller/main-controller.go index 2e6f46e18d9..18b5df244e4 100644 --- a/pkg/controller/main-controller.go +++ b/pkg/controller/main-controller.go @@ -231,8 +231,8 @@ func NewController( policyBindingInformer stsInformers.PolicyBindingInformer, serviceInformer coreinformers.ServiceInformer, hostsTemplate, - operatorVersion string) *Controller { - + operatorVersion string, +) *Controller { // Create event broadcaster // Add minio-controller types to the default Kubernetes Scheme so Events can be // logged for minio-controller types.