updated to return actual results from PLP

ministryofjustice · Dec 12, 2024 · 1363411 · 1363411
1 parent 7a585dc
commit 1363411
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/...n/uk/gov/justice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/PLPController.kt b/...n/uk/gov/justice/digital/hmpps/hmppsintegrationapi/controllers/v1/person/PLPController.kt
@@ -15,7 +15,7 @@ import org.springframework.web.bind.annotation.RestController
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.exception.EntityNotFoundException
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.DataResponse
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.InductionSchedule
-import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.ReviewSchedule
+import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.ReviewSchedules
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.UpstreamApiError
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.services.GetInductionScheduleForPersonService
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.services.GetReviewScheduleForPersonService
@@ -61,7 +61,7 @@ class PLPController(
   )
   fun getReviewSchedule(
     @Parameter(description = "A HmppsId ", example = "A123123") @PathVariable hmppsId: String,
-  ): DataResponse<ReviewSchedule> {
+  ): DataResponse<ReviewSchedules> {
     val response = getReviewScheduleForPersonService.execute(hmppsId)
 
     if (response.hasError(UpstreamApiError.Type.ENTITY_NOT_FOUND)) {

diff --git a/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/gateways/PLPGateway.kt b/src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/gateways/PLPGateway.kt
@@ -8,7 +8,6 @@ import uk.gov.justice.digital.hmpps.hmppsintegrationapi.extensions.WebClientWrap
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.extensions.WebClientWrapper.WebClientWrapperResponse
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.InductionSchedule
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.Response
-import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.ReviewSchedule
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.ReviewSchedules
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.UpstreamApi
 

diff --git a/...in/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/models/hmpps/ReviewSchedule.kt b/...in/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/models/hmpps/ReviewSchedule.kt
@@ -5,7 +5,6 @@ import com.fasterxml.jackson.annotation.JsonInclude
 import java.time.Instant
 import java.time.LocalDate
 
-
 @JsonIgnoreProperties(ignoreUnknown = true)
 @JsonInclude(JsonInclude.Include.USE_DEFAULTS)
 data class ReviewSchedules(

diff --git a/...uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/person/PLPIntegrationTest.kt b/...uk/gov/justice/digital/hmpps/hmppsintegrationapi/integration/person/PLPIntegrationTest.kt
@@ -25,7 +25,6 @@ class PLPIntegrationTest : IntegrationTestBase() {
       )
   }
 
-
   @Test
   fun `returns a persons review schedule`() {
     callApi("$basePath/K5995YZ/plp-review-schedule")
-Original file line number
+Diff line change
@@ Expand Up / @@ -25,7 +25,6 @@ class PLPIntegrationTest : IntegrationTestBase() { @@
           )
       }
       @Test
       fun `returns a persons review schedule`() {
         callApi("$basePath/K5995YZ/plp-review-schedule")
@@ Expand Down @@