Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-408 add encryption to remaining dynamo table #1744

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

jamesrwarren
Copy link
Contributor

@jamesrwarren jamesrwarren commented Nov 26, 2024

Purpose

This adds the encrypting to the ramaining dynamodb resource.

Fixes DDLS-408

Approach

Added the encryption. Additionally, I have created two new security groups instead of just amending the current ones. I'm doing it this way to avoid any down time. In subsequent PRs I will duplicate the settings for the cache sg for all the env services then in another PR remove the original. This will result in zero downtime. It's a bit more of a faff but I'll just add it to other PRs that I do.

Learning

NA

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@jamesrwarren jamesrwarren marked this pull request as ready for review November 26, 2024 11:43
@jamesrwarren jamesrwarren requested a review from a team as a code owner November 26, 2024 11:43
@jamesrwarren jamesrwarren merged commit f775ba8 into main Dec 3, 2024
37 checks passed
@jamesrwarren jamesrwarren deleted the DDLS-408b branch December 3, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants