Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-401 - Fix Inactive Lay Cleanup Job #1746

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Conversation

Raffers
Copy link
Contributor

@Raffers Raffers commented Nov 27, 2024

Purpose

Fixes the daily Inactive Lay User cleanup job

The previous PR to implement the changes & it's associated discussion - #1640
The rules in place on the cleanup-job -

public function findInactive($role = User::ROLE_LAY_DEPUTY): array

Fixes DDLS-401

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about DigiDeps

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@Raffers Raffers requested a review from a team as a code owner November 27, 2024 10:31
jamesrwarren
jamesrwarren previously approved these changes Nov 27, 2024
@Raffers Raffers merged commit 7ef8d31 into main Dec 2, 2024
37 checks passed
@Raffers Raffers deleted the DDLS-401-inactive-cleanup-job branch December 2, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants