Renovate Update Patch & Minor Updates

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence	Type	Update	Pending
@ministryofjustice/frontend	1.6.6 -> 1.8.0					dependencies	minor
anothrNick/github-tag-action	1.52.0 -> 1.67.0					action	minor
cypress	12.11.0 -> 12.15.0					devDependencies	minor
cypress/included	10.3.1 -> 10.11.0					final	minor
esbuild	^0.15.14 -> ^0.18.0					devDependencies	minor	0.18.9 (+2)
github.com/stretchr/testify	v1.8.1 -> v1.8.4					require	patch
golang	1.19.3-alpine -> 1.20.5-alpine					stage	minor
golang.org/x/sync	v0.0.0-20220722155255-886fb9371eb4 -> v0.3.0					require	minor
jquery (source)	3.6.4 -> 3.7.0					dependencies	minor
node	19.1.0-alpine3.16 -> 19.9.0-alpine3.16					stage	minor
node	19.8.1-alpine3.16 -> 19.9.0-alpine3.16					final	minor
sass	1.62.1 -> 1.63.6					devDependencies	minor

---

Release Notes

ministryofjustice/moj-frontend (@​ministryofjustice/frontend)

v1.8.0

Compare Source

Features

• filter component: add parameter for apply filters button text (#​493) (5362f1e)

v1.7.0

Compare Source

Features

• filter component: add filter submit attribute params to allow customisation of button (#​492) (a42dca8)

1.6.6 (2023-03-21)

Bug Fixes

• prototype: better support for GOV.UK Prototype Kit (#​466) (f2e6faa), closes #​465

1.6.5 (2023-03-10)

Bug Fixes

• sortable-table: fix sorting for tables with row headers (42bc5e1)

1.6.4 (2023-01-09)

Bug Fixes

• use syntax compatible with postcss-calc (#​435) (3f21884), closes #​433

1.6.4 (2023-01-09)

Bug Fixes

• use syntax compatible with postcss-calc (#​435) (3f21884), closes #​433

1.6.3 (2022-11-14)

Bug Fixes

• component: sort the columns of the sortable table on page load (#​406) (ed2056a)

1.6.2 (2022-10-31)

Bug Fixes

• deps: update dependency govuk-frontend to v4 (#​403) (1684def)

1.6.1 (2022-10-28)

Bug Fixes

• scrollable: fix CSS shadow effect (#​381) (dce18d4)

anothrNick/github-tag-action (anothrNick/github-tag-action)

v1.67.0: : improvements: tag strategy and tag listing for filtering

Compare Source

Sorting tags by date [https://github.com/anothrNick/github-tag-action/pull/2722 ]
Adding GIT_API_TAGGING false option to switch to cli tagging [https://github.com/anothrNick/github-tag-action/pull/210](https://togithub.com/anothrNick/github-tag-action/pull/210)10 ]

CLI tagging nowdays is more reliable for github actions permissions.

v1.66.0: : fixes: sigpipe 141 scenarios

Compare Source

In some cases if the repo contains hundreds of tags, since we set -e grep combined with git tag reads randomly exits with error 141.

v1.65.0: : fixes pre-release tag exists

Compare Source

Fixes a bug introduced in 1.64 that makes pre-releases error when following a release branch strategy.
More details here https://github.com/anothrNick/github-tag-action/issues/265

v1.64.0: : hotfix: in some cases git rev errors since set -e

Compare Source

v1.63.0: : Improvements: set node to lts and catch actions errors efficiently

Compare Source

v1.62.0: : More tests and outputs when default_bump set to NONE

Compare Source

This is a very minor release, adds outputs to workflows using default_bump none when there are no #comments found that trigger a commit bump.

v1.61.0: :Hotfix - Exclude validating the default branch when using branch_listory non full

Compare Source

Suggested by @​vancejc-mt in https://github.com/anothrNick/github-tag-action/issues/243

v1.60.0

Compare Source

v1.59.0: : Hotfix - gitlog full breaking rebase and squash merges

Compare Source

The current implementation of full git log breaks in squash and rebase due missing HEAD using suggestion from @​jonavos here https://github.com/anothrNick/github-tag-action/issues/232#issuecomment-1372299198 and changing approach to compare log history.

Please report back to https://github.com/anothrNick/github-tag-action/issues/232 if any further issues on use cases.

v1.58.0: : Exit with error if default branch is not set in non pr workflows

Compare Source

There are some cases where the default_branch is not available in the runner environment, This leads to no history of commits.
This change attempts to identify the default branch in this scenarios and error the user if the attempt fails and default_branch remains null

v1.57.0: : Skip bumps if there are no new commits in pre-release actrions re runs

Compare Source

Identified here https://github.com/anothrNick/github-tag-action/issues/233 the action was not skipping bumps if there where no new commits in pre-release mode when an action is re run creating extra tags.

This minor change applies the same behavior used in normal releases.

v1.56.0: : Get the default branch from env vars also allow to overwrite as parameter

Compare Source

This is a feature from a hotfix where we add the option to specify a default branch from parameters else we capture the default branch from the runner$GITHUB_BASE_REF var

v1.55.0: : Select last commit or full branch history

Compare Source

This version allows to set BRANCH_HISTORY full|last for the history verification for finding bump comments. See pr for examples https://github.com/anothrNick/github-tag-action/pull/218

v1.54.0

Compare Source

v1.53.0: : Fixing repo tag bumps

Compare Source

Fixes action versioning bumps.
From bug introduced in 1.50

cypress-io/cypress (cypress)

v12.15.0

Compare Source

Changelog: https://docs.cypress.io/guides/references/changelog#​12-15-0

v12.14.0

Compare Source

Changelog: https://docs.cypress.io/guides/references/changelog#​12-14-0

v12.13.0

Compare Source

Changelog: https://docs.cypress.io/guides/references/changelog#​12-13-0

v12.12.0

Compare Source

Changelog: https://docs.cypress.io/guides/references/changelog#​12-12-0

evanw/esbuild (esbuild)

v0.18.6

Compare Source

• Fix tree-shaking of classes with decorators (#​3164)

  This release fixes a bug where esbuild incorrectly allowed tree-shaking on classes with decorators. Each decorator is a function call, so classes with decorators must never be tree-shaken. This bug was a regression that was unintentionally introduced in version 0.18.2 by the change that enabled tree-shaking of lowered private fields. Previously decorators were always lowered, and esbuild always considered the automatically-generated decorator code to be a side effect. But this is no longer the case now that esbuild analyzes side effects using the AST before lowering takes place. This bug was fixed by considering any decorator a side effect.

• Fix a minification bug involving function expressions (#​3125)

  When minification is enabled, esbuild does limited inlining of const symbols at the top of a scope. This release fixes a bug where inlineable symbols were incorrectly removed assuming that they were inlined. They may not be inlined in cases where they were referenced by earlier constants in the body of a function expression. The declarations involved in these edge cases are now kept instead of being removed:

  // Original code
  {
    const fn = () => foo
    const foo = 123
    console.log(fn)
  }
  
  // Old output (with --minify-syntax)
  console.log((() => foo)());
  
  // New output (with --minify-syntax)
  {
    const fn = () => foo, foo = 123;
    console.log(fn);
  }

v0.18.5

Compare Source

• Implement auto accessors (#​3009)

  This release implements the new auto-accessor syntax from the upcoming JavaScript decorators proposal. The auto-accessor syntax looks like this:

  class Foo {
    accessor foo;
    static accessor bar;
  }
  new Foo().foo = Foo.bar;

  This syntax is not yet a part of JavaScript but it was added to TypeScript in version 4.9. More information about this feature can be found in microsoft/TypeScript#​49705. Auto-accessors will be transformed if the target is set to something other than esnext:

  // Output (with --target=esnext)
  class Foo {
    accessor foo;
    static accessor bar;
  }
  new Foo().foo = Foo.bar;
  
  // Output (with --target=es2022)
  class Foo {
    #foo;
    get foo() {
      return this.#foo;
    }
    set foo(_) {
      this.#foo = _;
    }
    static #bar;
    static get bar() {
      return this.#bar;
    }
    static set bar(_) {
      this.#bar = _;
    }
  }
  new Foo().foo = Foo.bar;
  
  // Output (with --target=es2021)
  var _foo, _bar;
  class Foo {
    constructor() {
      __privateAdd(this, _foo, void 0);
    }
    get foo() {
      return __privateGet(this, _foo);
    }
    set foo(_) {
      __privateSet(this, _foo, _);
    }
    static get bar() {
      return __privateGet(this, _bar);
    }
    static set bar(_) {
      __privateSet(this, _bar, _);
    }
  }
  _foo = new WeakMap();
  _bar = new WeakMap();
  __privateAdd(Foo, _bar, void 0);
  new Foo().foo = Foo.bar;

  You can also now use auto-accessors with esbuild's TypeScript experimental decorator transformation, which should behave the same as decorating the underlying getter/setter pair.

  Please keep in mind that this syntax is not yet part of JavaScript. This release enables auto-accessors in .js files with the expectation that it will be a part of JavaScript soon. However, esbuild may change or remove this feature in the future if JavaScript ends up changing or removing this feature. Use this feature with caution for now.

• Pass through JavaScript decorators (#​104)

  In this release, esbuild now parses decorators from the upcoming JavaScript decorators proposal and passes them through to the output unmodified (as long as the language target is set to esnext). Transforming JavaScript decorators to environments that don't support them has not been implemented yet. The only decorator transform that esbuild currently implements is still the TypeScript experimental decorator transform, which only works in .ts files and which requires "experimentalDecorators": true in your tsconfig.json file.

• Static fields with assign semantics now use static blocks if possible

  Setting useDefineForClassFields to false in TypeScript requires rewriting class fields to assignment statements. Previously this was done by removing the field from the class body and adding an assignment statement after the class declaration. However, this also caused any private fields to also be lowered by necessity (in case a field initializer uses a private symbol, either directly or indirectly). This release changes this transform to use an inline static block if it's supported, which avoids needing to lower private fields in this scenario:

  // Original code
  class Test {
    static #foo = 123
    static bar = this.#foo
  }
  
  // Old output (with useDefineForClassFields=false)
  var _foo;
  const _Test = class _Test {
  };
  _foo = new WeakMap();
  __privateAdd(_Test, _foo, 123);
  _Test.bar = __privateGet(_Test, _foo);
  let Test = _Test;
  
  // New output (with useDefineForClassFields=false)
  class Test {
    static #foo = 123;
    static {
      this.bar = this.#foo;
    }
  }

• Fix TypeScript experimental decorators combined with --mangle-props (#​3177)

  Previously using TypeScript experimental decorators combined with the --mangle-props setting could result in a crash, as the experimental decorator transform was not expecting a mangled property as a class member. This release fixes the crash so you can now combine both of these features together safely.

v0.18.4

Compare Source

• Bundling no longer unnecessarily transforms class syntax (#​1360, #​1328, #​1524, #​2416)

  When bundling, esbuild automatically converts top-level class statements to class expressions. Previously this conversion had the unfortunate side-effect of also transforming certain other class-related syntax features to avoid correctness issues when the references to the class name within the class body. This conversion has been reworked to avoid doing this:

  // Original code
  export class Foo {
    static foo = () => Foo
  }
  
  // Old output (with --bundle)
  var _Foo = class {
  };
  var Foo = _Foo;
  __publicField(Foo, "foo", () => _Foo);
  
  // New output (with --bundle)
  var Foo = class _Foo {
    static foo = () => _Foo;
  };

  This conversion process is very complicated and has many edge cases (including interactions with static fields, static blocks, private class properties, and TypeScript experimental decorators). It should already be pretty robust but a change like this may introduce new unintentional behavior. Please report any issues with this upgrade on the esbuild bug tracker.

  You may be wondering why esbuild needs to do this at all. One reason to do this is that esbuild's bundler sometimes needs to lazily-evaluate a module. For example, a module may end up being both the target of a dynamic import() call and a static import statement. Lazy module evaluation is done by wrapping the top-level module code in a closure. To avoid a performance hit for static import statements, esbuild stores top-level exported symbols outside of the closure and references them directly instead of indirectly.

  Another reason to do this is that multiple JavaScript VMs have had and continue to have performance issues with TDZ (i.e. "temporal dead zone") checks. These checks validate that a let, or const, or class symbol isn't used before it's initialized. Here are two issues with well-known VMs:

  • V8: https://bugs.chromium.org/p/v8/issues/detail?id=13723 (10% slowdown)
  • JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=199866 (1,000% slowdown!)

  JavaScriptCore had a severe performance issue as their TDZ implementation had time complexity that was quadratic in the number of variables needing TDZ checks in the same scope (with the top-level scope typically being the worst offender). V8 has ongoing issues with TDZ checks being present throughout the code their JIT generates even when they have already been checked earlier in the same function or when the function in question has already been run (so the checks have already happened).

  Due to esbuild's parallel architecture, esbuild both a) needs to convert class statements into class expressions during parsing and b) doesn't yet know whether this module will need to be lazily-evaluated or not in the parser. So esbuild always does this conversion during bundling in case it's needed for correctness (and also to avoid potentially catastrophic performance issues due to bundling creating a large scope with many TDZ variables).

• Enforce TDZ errors in computed class property keys (#​2045)

  JavaScript allows class property keys to be generated at run-time using code, like this:

  class Foo {
    static foo = 'foo'
    static [Foo.foo + '2'] = 2
  }

  Previously esbuild treated references to the containing class name within computed property keys as a reference to the partially-initialized class object. That meant code that attempted to reference properties of the class object (such as the code above) would get back undefined instead of throwing an error.

  This release rewrites references to the containing class name within computed property keys into code that always throws an error at run-time, which is how this JavaScript code is supposed to work. Code that does this will now also generate a warning. You should never write code like this, but it now should be more obvious when incorrect code like this is written.

• Fix an issue with experimental decorators and static fields (#​2629)

  This release also fixes a bug regarding TypeScript experimental decorators and static class fields which reference the enclosing class name in their initializer. This affected top-level classes when bundling was enabled. Previously code that does this could crash because the class name wasn't initialized yet. This case should now be handled correctly:

  // Original code
  class Foo {
    @​someDecorator
    static foo = 'foo'
    static bar = Foo.foo.length
  }
  
  // Old output
  const _Foo = class {
    static foo = "foo";
    static bar = _Foo.foo.length;
  };
  let Foo = _Foo;
  __decorateClass([
    someDecorator
  ], Foo, "foo", 2);
  
  // New output
  const _Foo = class _Foo {
    static foo = "foo";
    static bar = _Foo.foo.length;
  };
  __decorateClass([
    someDecorator
  ], _Foo, "foo", 2);
  let Foo = _Foo;

• Fix a minification regression with negative numeric properties (#​3169)

  Version 0.18.0 introduced a regression where computed properties with negative numbers were incorrectly shortened into a non-computed property when minification was enabled. This regression has been fixed:

  // Original code
  x = {
    [1]: 1,
    [-1]: -1,
    [NaN]: NaN,
    [Infinity]: Infinity,
    [-Infinity]: -Infinity,
  }
  
  // Old output (with --minify)
  x={1:1,-1:-1,NaN:NaN,1/0:1/0,-1/0:-1/0};
  
  // New output (with --minify)
  x={1:1,[-1]:-1,NaN:NaN,[1/0]:1/0,[-1/0]:-1/0};

v0.18.3

Compare Source

• Fix a panic due to empty static class blocks (#​3161)

  This release fixes a bug where an internal invariant that was introduced in the previous release was sometimes violated, which then caused a panic. It happened when bundling code containing an empty static class block with both minification and bundling enabled.

v0.18.2

Compare Source

• Lower static blocks when static fields are lowered (#​2800, #​2950, #​3025)

  This release fixes a bug where esbuild incorrectly did not lower static class blocks when static class fields needed to be lowered. For example, the following code should print 1 2 3 but previously printed 2 1 3 instead due to this bug:

  // Original code
  class Foo {
    static x = console.log(1)
    static { console.log(2) }
    static y = console.log(3)
  }
  
  // Old output (with --supported:class-static-field=false)
  class Foo {
    static {
      console.log(2);
    }
  }
  __publicField(Foo, "x", console.log(1));
  __publicField(Foo, "y", console.log(3));
  
  // New output (with --supported:class-static-field=false)
  class Foo {
  }
  __publicField(Foo, "x", console.log(1));
  console.log(2);
  __publicField(Foo, "y", console.log(3));

• Use static blocks to implement --keep-names on classes (#​2389)

  This change fixes a bug where the name property could previously be incorrect within a class static context when using --keep-names. The problem was that the name property was being initialized after static blocks were run instead of before. This has been fixed by moving the name property initializer into a static block at the top of the class body:

  // Original code
  if (typeof Foo === 'undefined') {
    let Foo = class {
      static test = this.name
    }
    console.log(Foo.test)
  }
  
  // Old output (with --keep-names)
  if (typeof Foo === "undefined") {
    let Foo2 = /* @​__PURE__ */ __name(class {
      static test = this.name;
    }, "Foo");
    console.log(Foo2.test);
  }
  
  // New output (with --keep-names)
  if (typeof Foo === "undefined") {
    let Foo2 = class {
      static {
        __name(this, "Foo");
      }
      static test = this.name;
    };
    console.log(Foo2.test);
  }

  This change was somewhat involved, especially regarding what esbuild considers to be side-effect free. Some unused classes that weren't removed by tree shaking in previous versions of esbuild may now be tree-shaken. One example is classes with static private fields that are transformed by esbuild into code that doesn't use JavaScript's private field syntax. Previously esbuild's tree shaking analysis ran on the class after syntax lowering, but with this release it will run on the class before syntax lowering, meaning it should no longer be confused by class mutations resulting from automatically-generated syntax lowering code.

v0.18.1

Compare Source

• Fill in null entries in input source maps (#​3144)

  If esbuild bundles input files with source maps and those source maps contain a sourcesContent array with null entries, esbuild previously copied those null entries over to the output source map. With this release, esbuild will now attempt to fill in those null entries by looking for a file on the file system with the corresponding name from the sources array. This matches esbuild's existing behavior that automatically generates the sourcesContent array from the file system if the entire sourcesContent array is missing.

• Support /* @​__KEY__ */ comments for mangling property names (#​2574)

  Property mangling is an advanced feature that enables esbuild to minify certain property names, even though it's not possible to automatically determine that it's safe to do so. The safe property names are configured via regular expression such as --mangle-props=_$ (mangle all properties ending in _).

  Sometimes it's desirable to also minify strings containing property names, even though it's not possible to automatically determine which strings are property names. This release makes it possible to do this by annotating those strings with /* @​__KEY__ */. This is a convention that Terser added earlier this year, and which esbuild is now following too: https://github.com/terser/terser/pull/1365. Using it looks like this:

  // Original code
  console.log(
    [obj.mangle_, obj.keep],
    [obj.get('mangle_'), obj.get('keep')],
    [obj.get(/* @​__KEY__ */ 'mangle_'), obj.get(/* @​__KEY__ */ 'keep')],
  )
  
  // Old output (with --mangle-props=_$)
  console.log(
    [obj.a, obj.keep],
    [obj.get("mangle_"), obj.get("keep")],
    [obj.get(/* @​__KEY__ */ "mangle_"), obj.get(/* @​__KEY__ */ "keep")]
  );
  
  // New output (with --mangle-props=_$)
  console.log(
    [obj.a, obj.keep],
    [obj.get("mangle_"), obj.get("keep")],
    [obj.get(/* @​__KEY__ */ "a"), obj.get(/* @​__KEY__ */ "keep")]
  );

• Support /* @​__NO_SIDE_EFFECTS__ */ comments for functions (#​3149)

  Rollup has recently added support for /* @​__NO_SIDE_EFFECTS__ */ annotations before functions to indicate that calls to these functions can be removed if the result is unused (i.e. the calls can be assumed to have no side effects). This release adds basic support for these to esbuild as well, which means esbuild will now parse these comments in input files and preserve them in output files. This should help people that use esbuild in combination with Rollup.

  Note that this doesn't necessarily mean esbuild will treat these calls as having no side effects, as esbuild's parallel architecture currently isn't set up to enable this type of cross-file tree-shaking information (tree-shaking decisions regarding a function call are currently local to the file they appear in). If you want esbuild to consider a function call to have no side effects, make sure you continue to annotate the function call with /* @​__PURE__ */ (which is the previously-established convention for communicating this).

v0.18.0

Compare Source

This release deliberately contains backwards-incompatible changes. To avoid automatically picking up releases like this, you should either be pinning the exact version of esbuild in your package.json file (recommended) or be using a version range syntax that only accepts patch upgrades such as ^0.17.0 or ~0.17.0. See npm's documentation about semver for more information.

The breaking changes in this release mainly focus on fixing some long-standing issues with esbuild's handling of tsconfig.json files. Here are all the changes in this release, in detail:

• Add a way to try esbuild online (#​797)

  There is now a way to try esbuild live on esbuild's website without installing it: https://esbuild.github.io/try/. In addition to being able to more easily evaluate esbuild, this should also make it more efficient to generate esbuild bug reports. For example, you can use it to compare the behavior of different versions of esbuild on the same input. The state of the page is stored in the URL for easy sharing. Many thanks to @​hyrious for creating https://hyrious.me/esbuild-repl/, which was the main inspiration for this addition to esbuild's website.

  Two forms of build options are supported: either CLI-style (example) or JS-style (example). Both are converted into a JS object that's passed to esbuild's WebAssembly API. The CLI-style argument parser is a custom one that simulates shell quoting rules, and the JS-style argument parser is also custom and parses a superset of JSON (basically JSON5 + regular expressions). So argument parsing is an approximate simulation of what happens for real but hopefully it should be close enough.

• Changes to esbuild's tsconfig.json support (#​3019):

  This release makes the following changes to esbuild's tsconfig.json support:

  • Using experimental decorators now requires "experimentalDecorators": true (#​104)

    Previously esbuild would always compile decorators in TypeScript code using TypeScript's experimental decorator transform. Now that standard JavaScript decorators are close to being finalized, esbuild will now require you to use "experimentalDecorators": true to do this. This new requirement makes it possible for esbuild to introduce a transform for standard JavaScript decorators in TypeScript code in the future. Such a transform has not been implemented yet, however.

  • TypeScript's target no longer affects esbuild's target (#​2628)

    Some people requested that esbuild support TypeScript's target setting, so support for it was added (in version 0.12.4). However, esbuild supports reading from multiple tsconfig.json files within a single build, which opens up the possibility that different files in the build have different language targets configured. There isn't really any reason to do this and it can lead to unexpected results. So with this release, the target setting in tsconfig.json will no longer affect esbuild's own target setting. You will have to use esbuild's own target setting instead (which is a single, global value).

  • TypeScript's jsx setting no longer causes esbuild to preserve JSX syntax (#​2634)

    TypeScript has a setting called jsx that controls how to transform JSX into JS. The tool-agnostic transform is called react, and the React-specific transform is called react-jsx (or react-jsxdev). There is also a setting called preserve which indicates JSX should be passed through untransformed. Previously people would run esbuild with "jsx": "preserve" in their tsconfig.json files and then be surprised when esbuild preserved their JSX. So with this release, esbuild will now ignore "jsx": "preserve" in tsconfig.json files. If you want to preserve JSX syntax with esbuild, you now have to use --jsx=preserve.

    Note: Some people have suggested that esbuild's equivalent jsx setting override the one in tsconfig.json. However, some projects need to legitimately have different files within the same build use different transforms (i.e. react vs. react-jsx) and having esbuild's global jsx setting override tsconfig.json would prevent this from working. This release ignores "jsx": "preserve" but still allows other jsx values in tsconfig.json files to override esbuild's global jsx setting to keep the ability for multiple files within the same build to use different transforms.

  • useDefineForClassFields behavior has changed (#​2584, #​2993)

    Class fields in TypeScript look like this (x is a class field):

    class Foo {
      x = 123
    }

    TypeScript has legacy behavior that uses assignment semantics instead of define semantics for class fields when useDefineForClassFields is enabled (in which case class fields in TypeScript behave differently than they do in JavaScript, which is arguably "wrong").

    This legacy behavior exists because TypeScript added class fields to TypeScript before they were added to JavaScript. The TypeScript team decided to go with assignment semantics and shipped their implementation. Much later on TC39 decided to go with define semantics for class fields in JavaScript instead. This behaves differently if the base class has a setter with the same name:

    class Base {
      set x(_) {
        console.log('x:', _)
      }
    }
    
    // useDefineForClassFields: false
    class AssignSemantics extends Base {
      constructor() {
        super()
        this.x = 123
      }
    }
    
    // useDefineForClassFields: true
    class DefineSemantics extends Base {
      constructor() {
        super()
        Object.defineProperty(this, 'x', { value: 123 })
      }
    }
    
    console.log(
      new AssignSemantics().x, // Calls the setter
      new DefineSemantics().x // Doesn't call the setter
    )

    When you run tsc, the value of useDefineForClassFields defaults to false when it's not specified and the target in tsconfig.json is present but earlier than ES2022. This sort of makes sense because the class field language feature was added in ES2022, so before ES2022 class fields didn't exist (and thus TypeScript's legacy behavior is active). However, TypeScript's target setting currently defaults to ES3 which unfortunately means that the useDefineForClassFields setting currently defaults to false (i.e. to "wrong"). In other words if you run tsc with all default settings, class fields will behave incorrectly.

    Previously esbuild tried to do what tsc did. That meant esbuild's version of useDefineForClassFields was false by default, and was also false if esbuild's --target= was present but earlier than es2022. However, TypeScript's legacy class field behavior is becoming increasingly irrelevant and people who expect class fields in TypeScript to work like they do in JavaScript are confused when they use esbuild with default settings. It's also confusing that the behavior of class fields would change if you changed the language target (even though that's exactly how TypeScript works).

    So with this release, esbuild will now only use the information in tsconfig.json to determine whether useDefineForClassFields is true or not. Specifically useDefineForClassFields will be respected if present, otherwise it will be false if target is present in tsconfig.json and is ES2021 or earlier, otherwise it will be true. Targets passed to esbuild's --target= setting will no longer affect useDefineForClassFields.

    Note that this means different directories in your build can have different values for this setting since esbuild allows different directories to have different tsconfig.json files within the same build. This should let you migrate your code one directory at a time without esbuild's --target= setting affecting the semantics of your code.

  • Add support for verbatimModuleSyntax from TypeScript 5.0

    TypeScript 5.0 added a new option called verbatimModuleSyntax that deprecates and replaces two older options, preserveValueImports and importsNotUsedAsValues. Setting verbatimModuleSyntax to true in tsconfig.json tells esbuild to not drop unused import statements. Specifically esbuild now treats "verbatimModuleSyntax": true as if you had specified both "preserveValueImports": true and "importsNotUsedAsValues": "preserve".

  • Add multiple inheritance for tsconfig.json from TypeScript 5.0

    TypeScript 5.0 now allows multiple inheritance for tsconfig.json files. You can now pass an array of filenames via the extends parameter and your tsconfig.json will start off containing properties from all of those configuration files, in order. This release of esbuild adds support for this new TypeScript feature.

  • Remove support for moduleSuffixes (#​2395)

    The community has requested that esbuild remove support for TypeScript's moduleSuffixes feature, so it has been removed in this release. Instead you can use esbuild's --resolve-extensions= feature to select which module suffix you want to build with.

  • Apply --tsconfig= overrides to stdin and virtual files (#​385, #​2543)

    When you override esbuild's automatic tsconfig.json file detection with --tsconfig= to pass a specific tsconfig.json file, esbuild previously didn't apply these settings to source code passed via the stdin API option or to TypeScript files from plugins that weren't in the file namespace. This release changes esbuild's behavior so that settings from tsconfig.json also apply to these source code files as well.

  • Support --tsconfig-raw= in build API calls (#​943, #​2440)

    Previously if you wanted to override esbuild's automatic tsconfig.json file detection, you had to create a new tsconfig.json file and pass the file name to esbuild via the --tsconfig= flag. With this release, you can now optionally use --tsconfig-raw= instead to pass the contents of tsconfig.json to esbuild directly instead of passing the file name. For example, you can now use --tsconfig-raw={"compilerOptions":{"experimentalDecorators":true}} to enable TypeScript experimental decorators directly using a command-line flag (assuming you escape the quotes correctly using your current shell's quoting rules). The --tsconfig-raw= flag previously only worked with transform API calls but with this release, it now works with build API calls too.

  • Ignore all tsconfig.json files in node_modules (#​276, #​2386)

    This changes esbuild's behavior that applies tsconfig.json to all files in the subtree of the directory containing tsconfig.json. In version 0.12.7, esbuild started ignoring tsconfig.json files inside node_modules folders. The rationale is that people typically do this by mistake and that doing this intentionally is a rare use case that doesn't need to be supported. However, this change only applied to certain syntax-specific settings (e.g. jsxFactory) but did not apply to path resolution settings (e.g. paths). With this release, esbuild will now ignore all tsconfig.json files in node_modules instead of only ignoring certain settings.

  • Ignore tsconfig.json when resolving paths within node_modules (#​2481)

    Previously fields in tsconfig.json related to path resolution (e.g. paths) were respected for all files in the subtree containing that tsconfig.json file, even within a nested node_modules subdirectory. This meant that a project's paths settings could potentially affect any bundled packages. With this release, esbuild will no longer use tsconfig.json settings during path resolution inside nested node_modules subdirectories.

  • Prefer .js over .ts within node_modules (#​3019)

    The default list of implicit extensions that esbuild will try appending to import paths contains .ts before .js. This makes it possible to bundle TypeScript projects that reference other files in the project using extension-less imports (e.g. ./some-file to load ./some-file.ts instead of ./some-file.js). However, this behavior is undesirable within node_modules directories. Some package authors publish both their original TypeScript code and their compiled JavaScript code side-by-side. In these cases, esbuild should arguably be using the compiled JavaScript files instead of the original TypeScript files because the TypeScript compilation settings for files within the package should be determined by the package author, not the user of esbuild. So with this release, esbuild will now prefer implicit .js extensions over .ts when searching for import paths within node_modules.

  These changes are intended to improve esbuild's compatibility with tsc and reduce the number of unfortunate behaviors regarding tsconfig.json and esbuild.

• Add a workaround for bugs in Safari 16.2 and earlier (#​3072)

  Safari's JavaScript parser had a bug (which has now been fixed) where at least something about unary/binary operators nested inside default arguments nested inside either a function or class expression was incorrectly considered a syntax error if that expression was the target of a property assignment. Here are some examples that trigger this Safari bug:

  ❱ x(function (y = -1) {}.z = 2)
  SyntaxError: Left hand side of operator '=' must be a reference.
  
  ❱ x(class { f(y = -1) {} }.z = 2)
  SyntaxError: Left hand side of operator '=' must be a reference.
  

  It's not clear what the exact conditions are that trigger this bug. However, a workaround for this bug appears to be to post-process your JavaScript to wrap any in function and class declarations that are the direct target of a property access expression in parentheses. That's the workaround that UglifyJS applies for this issue: mishoo/UglifyJS#​2056. So that's what esbuild now does starting with this release:

  // Original code
  x(function (y = -1) {}.z = 2, class { f(y = -1) {} }.z = 2)
  
  // Old output (with --minify --target=safari16.2)
  x(function(c=-1){}.z=2,class{f(c=-1){}}.z=2);
  
  // New output (with --minify --target=safari16.2)
  x((function(c=-1){}).z=2,(class{f(c=-1){}}).z=2);

  This fix is not enabled by default. It's only enabled when --target= contains Safari 16.2 or earlier, such as with --target=safari16.2. You can also explicitly enable or disable this specific transform (called function-or-class-property-access) with --supported:function-or-class-property-access=false.

• Fix esbuild's TypeScript type declarations to forbid unknown properties (#​3089)

  Version 0.17.0 of esbuild introduced a specific form of function overloads in the TypeScript type definitions for esbuild's API calls that looks like this:

  interface TransformOptions {
    legalComments?: 'none' | 'inline' | 'eof' | 'external'
  }
  
  interface TransformResult<ProvidedOptions extends TransformOptions = TransformOptions> {
    legalComments: string | (ProvidedOptions['legalComments'] extends 'external' ? never : undefined)
  }
  
  declare function transformSync<ProvidedOptions extends TransformOptions>(input: string, options?: ProvidedOptions): TransformResult<ProvidedOptions>
  declare function transformSync(input: string, options?: TransformOptions): TransformResult

  This more accurately reflects how esbuild's JavaScript API behaves. The result object returned by transformSync only has the legalComments property if you pass legalComments: 'external':

  // These have type "string | undefined"
  transformSync('').legalComments
  transformSync('', { legalComments: 'eof' }).legalComments
  
  // This has type "string"
  transformSync('', { legalComments: 'external' }).legalComments

  However, this form of function overloads unfortunately allows typos (e.g. egalComments) to pass the type checker without generating an error as TypeScript allows all objects with unknown properties to extend TransformOptions. These typos result in esbuild's API throwing an error at run-time.

  To prevent typos during type checking, esbuild's TypeScript type definitions will now use a different form that looks like this:

  type SameShape<Out, In extends Out> = In & { [Key in Exclude<keyof In, keyof Out>]: never }
  
  inter

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[github-actions]

Unit Test Results

195 tests  ±0   195 ✔️ ±0   0s ⏱️ ±0s
    5 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 542f38a. ± Comparison against base commit 9855a64.

♻️ This comment has been updated with latest results.