Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's use ocamlformat #232

Open
emillon opened this issue Mar 7, 2019 · 4 comments
Open

Let's use ocamlformat #232

emillon opened this issue Mar 7, 2019 · 4 comments

Comments

@emillon
Copy link
Contributor

emillon commented Mar 7, 2019

Hi,

ocamlformat is getting pretty mature, and so far it's been a good experience for the new mirage libraries.

I suggest that we build on that traction and start converting existing libraries. Tools like merge-fmt will help for existing PRs.

If there's interest, I'll try to write a configuration that's close to the existing conventions.

Thanks!
@samoht
Copy link
Member

samoht commented Mar 7, 2019

That would be great!

@avsm
Copy link
Member

avsm commented Mar 7, 2019

Rather than keeping the existing conventions, I'd prefer to use the standard format in the forthcoming ocamlformat 0.9 release...

@emillon
Copy link
Contributor Author

emillon commented Mar 7, 2019

OK, we can try that.

@samoht
Copy link
Member

samoht commented Mar 7, 2019

@avsm or we can pick the "right" conventions and try to change the upstream default in 1.0 :-)

@emillon emillon mentioned this issue Mar 8, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@avsm @samoht @emillon