24 bit types

[avsm]

I notice a comment in ocaml-tls that should be integrated into cstruct:

(* HACK: 24 bits type not in cstruct *)
let get_uint24_len buf =
  (Cstruct.BE.get_uint16 buf 0) * 0x100 + (Cstruct.get_uint8 buf 2)

let set_uint24_len buf num =
  Cstruct.BE.set_uint16 buf 0 (num / 0x100);
  Cstruct.set_uint8 buf 2 (num mod 0x100)

[jgjl]

Would it make sense to switch to Stdint (https://github.com/andrenth/ocaml-stdint) for value types to improve this issue? They have a uint24 type and others in one byte steps up to 128bits.

[hannesm]

as a matter of fact, I discovered that 48bit fields are also in use -- Time Signed u_int48_t seconds since 1-Jan-70 UTC from https://tools.ietf.org/html/rfc2845 (if anyone is interested)... 48bit need to be converted to int64 if we want to stay 32bit compatible