More bounds on views #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh, sorry - commented on outdated diff |
|
@hannes: could you run with this diff on the tls stack and check for regressions? They should be bugs in the TLS code if any do happen, but just to be sure. I'm testing net stack. |
|
I run both ocaml-tls and ocaml-x509 test suite, which parse and unparse cstruct data quite heavily. both are fine with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bounds checks for
Cstruct.BE/LEfunctions that violate a view. Previously, only bounds errors on the underlying buffers would raise.Bug #25, reported by @yomimono in mirage/mirage-tcpip#56.