-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra Headers support in CLI #430
Labels
enhancement
New feature or request
Comments
Sure I’m open to a PR addressing thing 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi 👋,
I'm opening this issue to ask if a new config option
extraHeaders
would be interesting. In our setup (behind Cloudflare Access) any programmatic access needs to provide two extra headers, provided as environment variables to the Docker container. In an effort to get rid of our mitm proxy in CI that just adds the headers to all requests, I was instead looking at a native solution.To me it looked like the only place this needs to be added (in the CLI, since all the rest is inside the docker container that is the application behind Access) is here in
project-fetcher.ts
:accent/cli/src/services/project-fetcher.ts
Lines 114 to 121 in 58b78e2
document.ts
- in this second case the simplest solution would be to (add it to config, pass it the Document class) and add it the theprivate authorizationHeader()
method:accent/cli/src/services/document.ts
Lines 248 to 250 in 58b78e2
fetch()
could all be modified, which one would be preferable?In general, would this extra headers feature be something you would be interested in supporting? Happy to work on a PR implementing it.
The text was updated successfully, but these errors were encountered: