Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Retrieval Errors Nicely #210

Open
1 task done
AdalynBlack opened this issue Mar 6, 2024 · 0 comments
Open
1 task done

Handle Retrieval Errors Nicely #210

AdalynBlack opened this issue Mar 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@AdalynBlack
Copy link

Extension information

All

Steps to reproduce

N/A

Miru version

1.8.1

Other details

This isn't necessarily an issue, more a feature request, but it might be nice to have better error handling for when requests fail or otherwise don't behave as expected. In the previous issue I made, #209, I was unable to favorite the show I was researching because of a partial API failure. With proper data validation though, the page could still be allowed to open so that the description can be viewed, favorites made, etc. As is, I am unable to do either of those things because of the episode error. Instead, this error could be relegated elsewhere, like an in-app notification/banner, or even just in the episodes section itself for a quick and dirty fix. I whipped up a quick demo showing that latter option just to show how it looks in-app:

image

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
@AdalynBlack AdalynBlack added the bug Something isn't working label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant