Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ui): add tests for from_curl() and close() #266

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

rcasia
Copy link
Contributor

@rcasia rcasia commented Oct 6, 2024

Continuation of #240

This PR contains tests for:

  • from_curl()
  • close()

My intention is to continue adding tests, but on different PRs. I tried to avoid having loads of API calls written on the tests by using a test helper.

@rcasia rcasia force-pushed the test/add-ui-tests branch 2 times, most recently from 08caad2 to 9dbb7f5 Compare October 6, 2024 18:51
@gorillamoe gorillamoe self-assigned this Oct 7, 2024
@gorillamoe gorillamoe added the enhancement New feature or request label Oct 7, 2024
Copy link
Member

@gorillamoe gorillamoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😍

@gorillamoe gorillamoe merged commit 9140eed into mistweaverco:main Oct 7, 2024
2 checks passed
iamxiaojianzheng pushed a commit to iamxiaojianzheng/kulala.nvim that referenced this pull request Oct 24, 2024
* tests(ui): add unit tests for UI functionality

* pass linter

* linter mistweaverco#2

* test(ui): add tests for from_curl() and close()

* fix(tests): GLOBALS.UI_ID instead of hard-coded

---------

Co-authored-by: Michal Vyskocil <michal.vyskocil@gmail.com>
Co-authored-by: Marco Kellershoff <marco@kellershoff.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants